From: Steven Rostedt <rostedt@goodmis.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jesper Juhl <jj@chaosbits.net>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
greg@kroah.com, joe@perches.com, akpm@linux-foundation.org
Subject: Re: [PATCH][rfc] Use int as return type of main in arch/x86/boot/main.c
Date: Mon, 14 Mar 2011 15:04:05 -0400 [thread overview]
Message-ID: <20110314190404.GB20259@home.goodmis.org> (raw)
In-Reply-To: <4D7E470E.8090204@zytor.com>
On Mon, Mar 14, 2011 at 09:49:18AM -0700, H. Peter Anvin wrote:
> On 03/14/2011 04:32 AM, Harry Wei wrote:
> > On Sun, Mar 13, 2011 at 11:00:09PM +0100, Jesper Juhl wrote:
> >> I believe the return type of main should always be 'int'.
> >>
> >> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > Acked-by: Harry Wei <harryxiyou@gmail.com>
>
> It would make more sense to rename the function to something other than
> main().
Right, maybe "boot_start"?
-- Steve
next prev parent reply other threads:[~2011-03-14 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 22:00 Jesper Juhl
2011-03-14 11:32 ` Harry Wei
2011-03-14 16:49 ` H. Peter Anvin
2011-03-14 19:04 ` Steven Rostedt [this message]
2011-03-14 23:35 ` Jesper Juhl
2011-03-14 19:03 ` Steven Rostedt
2011-03-14 22:50 ` H. Peter Anvin
2011-03-15 2:31 ` Steven Rostedt
2011-03-15 13:55 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314190404.GB20259@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=jj@chaosbits.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®