Re: [PATCH] char/ipmi: fix cleanup_one_si section mismatch

[Randy Dunlap <randy.dunlap@oracle.com>]

On Tue, 15 Feb 2011 11:52:45 +0200 Sergey Senozhatsky wrote:

> 
> commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
> Author: Corey Minyard<minyard@acm.org>
> Date:   Thu Feb 10 16:08:38 2011 -0600
> 
>      char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver
> 
> 
> Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit 
> init_ipmi_si. Remove __exit annotation from cleanup_ipmi_si.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Acked-by: Corey Minyard <cminyard@mvista.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> ---
> 
>  drivers/char/ipmi/ipmi_si_intf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 7855f9f..94cd2ce 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
>  	kfree(to_clean);
>  }
>  
> -static void __exit cleanup_ipmi_si(void)
> +static void cleanup_ipmi_si(void)
>  {
>  	struct smi_info *e, *tmp_e;
>  
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***