From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Saeed Bishara <saeed.bishara@gmail.com>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH] Avoid indefinite wait in smp_call_function_many() if cpumask is modified
Date: Tue, 15 Mar 2011 18:46:29 +0000 [thread overview]
Message-ID: <20110315184629.GB3620@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110315181941.26948.65323.stgit@e102109-lin.cambridge.arm.com>
On Tue, Mar 15, 2011 at 06:20:56PM +0000, Catalin Marinas wrote:
> On ARM processors (and not only) with software broadcasting of the TLB
> maintenance operations, smp_call_function_many() is given a
> mm_cpumask(mm) as argument. This cpumask may be modified (bits cleared)
> during the smp_call_function_many() execution as a result of other
> events like ASID roll-over.
We shouldn't be modifying a mask which has been passed into one of these
functions. Having masks change beneath a function which is actively
using it and can wait is an obvious recipe for problems and races.
next prev parent reply other threads:[~2011-03-15 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 18:20 Catalin Marinas
2011-03-15 18:46 ` Russell King - ARM Linux [this message]
2011-03-15 22:36 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315184629.GB3620@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saeed.bishara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®