From: Christoph Hellwig <hch@infradead.org>
To: Theodore Tso <tytso@MIT.EDU>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Dave Chinner <david@fromorbit.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] VFS - the first pile
Date: Wed, 16 Mar 2011 09:07:28 -0400 [thread overview]
Message-ID: <20110316130728.GB30866@infradead.org> (raw)
In-Reply-To: <B0CB85F7-23A7-45EA-848E-8B2701545371@mit.edu>
On Wed, Mar 16, 2011 at 07:46:40AM -0400, Theodore Tso wrote:
>
> On Mar 16, 2011, at 3:21 AM, Al Viro wrote:
>
> > BTW, you want to update 005 in there - we are back to correct "maximum
> > is 40 symlinks total, 8 levels on nesting" for all syscalls. Add the
> > 41st symlink to your chain in testcase ;-)
>
> Unless there's a way to read out these limits, I'm not sure it's a good idea
> to add a test like that to xfstests --- it's too fragile since at some point
> we might change what those limits might be.
>
> Also, xfstests is primarily intended to be a file system level stress tester
> testing for correctness, and issues of whether we blow up on the 40th,
> 41st, or 42nd symlink seems more like an ABI issue --- and even there I'm
> not sure the ABI specification should be quite that detailed over what's
> allowed and not allowed.
That's not what it tests anyway. It tests that we get ELOOP at some
point, and do not blow the stack. Which is someting that older Linux
code used to do.
next prev parent reply other threads:[~2011-03-16 13:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 21:32 Al Viro
2011-03-15 22:02 ` Sam Ravnborg
2011-03-15 22:18 ` Al Viro
2011-03-15 22:47 ` Linus Torvalds
2011-03-15 23:02 ` Al Viro
2011-03-16 6:19 ` Dave Chinner
2011-03-16 6:51 ` Al Viro
2011-03-16 7:21 ` Al Viro
2011-03-16 11:46 ` Theodore Tso
2011-03-16 13:07 ` Christoph Hellwig [this message]
2011-03-16 13:15 ` Al Viro
2011-03-16 13:18 ` Christoph Hellwig
2011-03-16 13:05 ` Christoph Hellwig
2011-03-16 13:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316130728.GB30866@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@MIT.EDU \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®