Re: [PATCH 1/2 v2] watchdog, nmi: Allow hardlockup to panic by default

[Andrew Morton <akpm@linux-foundation.org>]

On Mon,  7 Mar 2011 16:37:39 -0500 Don Zickus <dzickus@redhat.com> wrote:

> Add a Kconfig option to allow users to set the hardlockup to panic
> by default.  Also add in a 'nmi_watchdog=nopanic' to override this.
> 

Changelog forgot to tell us "why".

>  			Format: [state][,regs][,debounce][,die]
>  
>  	nmi_watchdog=	[KNL,BUGS=X86] Debugging features for SMP kernels
> -			Format: [panic,][num]
> +			Format: [panic,][nopanic,][num]

It would be better to support panic=[0|1], if that can be simply done
in a back-compatible fashion.

>  static int __init hardlockup_panic_setup(char *str)
>  {
>  	if (!strncmp(str, "panic", 5))
>  		hardlockup_panic = 1;
> +	else if (!strncmp(str, "nopanic", 5))

s/5/7/

> +		hardlockup_panic = 0;
>  	else if (!strncmp(str, "0", 1))
>  		watchdog_enabled = 0;
>  	return 1;