From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755091Ab1CQTJc (ORCPT ); Thu, 17 Mar 2011 15:09:32 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:37836 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751924Ab1CQTJ3 (ORCPT ); Thu, 17 Mar 2011 15:09:29 -0400 Date: Thu, 17 Mar 2011 19:09:32 +0000 From: Alan Cox To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, dzickus@redhat.com Subject: Re: [PATCH]: SMBIOS: Add initial code and export version via sysfs Message-ID: <20110317190932.074949b4@lxorguk.ukuu.org.uk> In-Reply-To: <20110317135754.25241.88177.sendpatchset@prarit.bos.redhat.com> References: <20110317135754.25241.88177.sendpatchset@prarit.bos.redhat.com> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static struct class smbios_class = { > + .name = "smbios", > + .dev_release = (void(*)(struct device *)) kfree, > +}; I thought the policy was no new classes- Greg ? > + smbios_iounmap(buf, sizeof(*smbios_step)); > + printk(KERN_INFO "SMBIOS: Invalid STEP table checksum = %u\n", > + chksum1); Surely this isn't INFO ?