From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
To: nikai@nikai.net
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nilfs2: merge list_del()/list_add_tail() to list_move_tail()
Date: Mon, 21 Mar 2011 00:34:12 +0900 (JST) [thread overview]
Message-ID: <20110321.003412.212697075.ryusuke@osrg.net> (raw)
In-Reply-To: <20110319164530.6cc75cb2@absol.kitzblitz>
On Sat, 19 Mar 2011 16:45:30 +0100, Nicolas Kaiser wrote:
> Merge list_del() + list_add_tail() to list_move_tail().
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> fs/nilfs2/inode.c | 3 +--
> fs/nilfs2/segment.c | 6 ++----
> 2 files changed, 3 insertions(+), 6 deletions(-)
Thanks, applied both patches.
Ryusuke Konishi
> diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c
> index d5625be..84f1b76 100644
> --- a/fs/nilfs2/inode.c
> +++ b/fs/nilfs2/inode.c
> @@ -873,8 +873,7 @@ int nilfs_set_file_dirty(struct inode *inode, unsigned nr_dirty)
> return -EINVAL; /* NILFS_I_DIRTY may remain for
> freeing inode */
> }
> - list_del(&ii->i_dirty);
> - list_add_tail(&ii->i_dirty, &nilfs->ns_dirty_files);
> + list_move_tail(&ii->i_dirty, &nilfs->ns_dirty_files);
> set_bit(NILFS_I_QUEUED, &ii->i_state);
> }
> spin_unlock(&nilfs->ns_inode_lock);
> diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
> index afe4f21..5deeadd 100644
> --- a/fs/nilfs2/segment.c
> +++ b/fs/nilfs2/segment.c
> @@ -1991,8 +1991,7 @@ static int nilfs_segctor_collect_dirty_files(struct nilfs_sc_info *sci,
>
> clear_bit(NILFS_I_QUEUED, &ii->i_state);
> set_bit(NILFS_I_BUSY, &ii->i_state);
> - list_del(&ii->i_dirty);
> - list_add_tail(&ii->i_dirty, &sci->sc_dirty_files);
> + list_move_tail(&ii->i_dirty, &sci->sc_dirty_files);
> }
> spin_unlock(&nilfs->ns_inode_lock);
>
> @@ -2014,8 +2013,7 @@ static void nilfs_segctor_drop_written_files(struct nilfs_sc_info *sci,
> clear_bit(NILFS_I_BUSY, &ii->i_state);
> brelse(ii->i_bh);
> ii->i_bh = NULL;
> - list_del(&ii->i_dirty);
> - list_add_tail(&ii->i_dirty, &ti->ti_garbage);
> + list_move_tail(&ii->i_dirty, &ti->ti_garbage);
> }
> spin_unlock(&nilfs->ns_inode_lock);
> }
> --
> 1.7.3.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2011-03-20 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 15:45 Nicolas Kaiser
2011-03-20 15:34 ` Ryusuke Konishi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321.003412.212697075.ryusuke@osrg.net \
--to=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®