From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jack Stone <jwjstone@fastmail.fm>, Mac <kmac@poczta.fm>,
linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: 'scheduling while atomic' during ppp connection on 2.6.37.1 and 2.6.38
Date: Mon, 21 Mar 2011 11:02:14 +0000 [thread overview]
Message-ID: <20110321110214.5174f1b2@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4D87173D.50906@suse.cz>
> Anyway is the test needed at all? I.e. could
> tty->ops->write/chars_in_buffer/ntty_write_room be called with
> port->port.count == 0 at all?
I'm not entirely sure what the Nozomi driver is trying to do. Generally
any case a driver is looking at port->port.count it's a bug and should
not matter with the tty krefs. However the chances are it should be
testing *something* instead in this case.
Alan
next prev parent reply other threads:[~2011-03-21 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 22:06 Mac
2011-03-20 18:42 ` Jack Stone
2011-03-20 21:52 ` Jiri Slaby
2011-03-20 23:09 ` Jack Stone
2011-03-20 21:58 ` Alan Cox
2011-03-20 23:05 ` Jack Stone
2011-03-21 11:27 ` Alan Cox
2011-03-21 17:40 ` Jack Stone
2011-03-21 9:15 ` Jiri Slaby
2011-03-21 11:02 ` Alan Cox [this message]
2011-03-31 20:53 ` Jiri Slaby
2011-03-31 21:39 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2011-03-19 21:56 Mac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321110214.5174f1b2@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=jwjstone@fastmail.fm \
--cc=kmac@poczta.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®