From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Nguyen Dinh-R00091 <R00091@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"arnaud.patard@rtp-net.org" <arnaud.patard@rtp-net.org>,
Vaidyanathan Ranjani-RA5478 <RA5478@freescale.com>,
Zhang Lily-R58066 <R58066@freescale.com>,
"festevam@gmail.com" <festevam@gmail.com>
Subject: Re: [PATCHv4 3/3] ARM: mx51: Add support for low power suspend on MX51
Date: Mon, 21 Mar 2011 15:48:33 +0000 [thread overview]
Message-ID: <20110321154833.GD4340@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <56132A77AB93C141BF06E6B96CA6CFEA1BC0AF@039-SN1MPN1-004.039d.mgd.msft.net>
On Mon, Mar 21, 2011 at 02:53:21PM +0000, Nguyen Dinh-R00091 wrote:
> >On Fri, Mar 18, 2011 at 10:21:24AM -0500, Dinh.Nguyen@freescale.com wrote:
> >> +#include <linux/suspend.h>
> >> +#include <linux/clk.h>
> >> +#include <asm/mach/map.h>
> >> +#include <asm/cacheflush.h>
> >> +#include <asm/tlb.h>
> >> +#include <mach/system.h>
> >> +#include "crm_regs.h"
> >
> >Why does the code below require asm/mach/map.h ?
>
> map.h can be replaced by linux/io.h for the __raw_writel().
>
> >Why does it require asm/tlb.h ?
>
> asm/tlb is for the local_flush_tlb_all() call.
I think you want asm/tlbflush.h rather than the tlb shootdown stuff in
asm/tlb.h.
next prev parent reply other threads:[~2011-03-21 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 15:21 [PATCHv4 1/3] ARM: mx51: Add entry for gpc_dvfs_clk Dinh.Nguyen
2011-03-18 15:21 ` [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI Dinh.Nguyen
2011-03-18 15:21 ` [PATCHv4 3/3] ARM: mx51: Add support for low power suspend on MX51 Dinh.Nguyen
2011-03-18 15:25 ` Russell King - ARM Linux
2011-03-21 14:53 ` Nguyen Dinh-R00091
2011-03-21 15:48 ` Russell King - ARM Linux [this message]
2011-03-18 15:30 ` [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI Fabio Estevam
2011-03-18 15:34 ` Nguyen Dinh-R00091
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321154833.GD4340@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=R00091@freescale.com \
--cc=R58066@freescale.com \
--cc=RA5478@freescale.com \
--cc=arnaud.patard@rtp-net.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®