From: torbenh <torbenh@gmx.de>
To: john stultz <johnstul@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/5] RFC genirq: Add IRQ timestamping
Date: Tue, 22 Mar 2011 14:32:08 +0100 [thread overview]
Message-ID: <20110322133208.GB5507@siel.b> (raw)
In-Reply-To: <AANLkTikt95R5DT3cTkPbTia9PpJqUr55v_g_xVN_AQtf@mail.gmail.com>
On Mon, Mar 21, 2011 at 07:33:26PM -0700, john stultz wrote:
> On Mon, Mar 21, 2011 at 4:59 AM, Torben Hohn <torbenh@gmx.de> wrote:
> > + if (desc->status & IRQ_TIMESTAMP)
> > + getrawmonotonic(&desc->last_timestamp);
> > +
>
> I suspect you probably want some very clear comments around why you
> chose timestamps based on CLOCK_MONOTONIC_RAW instead of
> CLOCK_MONOTONIC. Likely in the code as well as in the commit log.
I really dont know which clock would be the most useful one.
CLOCK_MONOTONIC_RAW seems to be more suitable to drive dlls.
But the network layer probably wants CLOCK_MONOTONIC or
even CLOCK_REALTIME.
I didnt put much thought in this point, because it requires a broader
discussion, I think.
>
> thanks
> -john
--
torben Hohn
prev parent reply other threads:[~2011-03-22 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 11:59 Torben Hohn
2011-03-21 11:59 ` [PATCH 2/5] RFC genirq: add function to retrieve timestamp from irqdesc Torben Hohn
2011-03-21 11:59 ` [PATCH 3/5] RFC genirq: save irq timestamps in void *dev_id Torben Hohn
2011-03-21 11:59 ` [PATCH 4/5] RFC genirq: allow dynamic switching of timestamping irqs Torben Hohn
2011-03-21 11:59 ` [PATCH 5/5] RFC genirq: enforce dev_id to be struct timespec * with IRQF_TIMESTAMP Torben Hohn
2011-03-21 12:43 ` [PATCH 1/5] RFC genirq: Add IRQ timestamping torbenh
2011-03-22 2:33 ` john stultz
2011-03-22 13:32 ` torbenh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322133208.GB5507@siel.b \
--to=torbenh@gmx.de \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®