mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Korty <joe.korty@ccur.com>
To: paulmck@linux.vnet.ibm.com
Cc: fweisbec@gmail.com, peterz@infradead.org, laijs@cn.fujitsu.com,
	mathieu.desnoyers@efficios.com, dhowells@redhat.com,
	loic.minier@linaro.org, dhaval.giani@gmail.com,
	tglx@linutronix.de, josh@joshtriplett.org,
	houston.jim@comcast.net, andi@firstfloor.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 22/24] jrcu: precise vs sloppy sample timing
Date: Thu, 24 Mar 2011 13:48:04 -0400	[thread overview]
Message-ID: <20110324174804.GA18958@tsunami.ccur.com> (raw)

jrcu: test harness: increase sampling period precision.

Normally, jrcu tries to 'catch a ride' with any other
local timer interrupt happening on the monitoring cpu.
It does this through the hrtimer 'slop' mechanism.
Such sloppiness, though, defeats attempts to stress-test
jrcu via shortened sampling periods.

The precise/sloppy state is changeable at runtime:

    echo precise=1 >/sys/kernel/debug/rcu/rcudata
    echo precise=0 >/sys/kernel/debug/rcu/rcudata

Signed-off-by: Joe Korty <joe.korty@ccur.com>

Index: b/kernel/jrcu.c
===================================================================
--- a/kernel/jrcu.c
+++ b/kernel/jrcu.c
@@ -137,6 +137,8 @@ static int rcu_hz = RCU_HZ;
 static int rcu_hz_period_us = RCU_HZ_PERIOD_US;
 static int rcu_hz_delta_us = RCU_HZ_DELTA_US;
 
+static int rcu_hz_precise;
+
 int rcu_scheduler_active __read_mostly;
 int rcu_nmi_seen __read_mostly;
 
@@ -436,7 +438,8 @@ static enum hrtimer_restart rcu_timer_fu
 	raise_softirq(RCU_SOFTIRQ);
 
 	next = ktime_add_ns(ktime_get(), rcu_hz_period_ns);
-	hrtimer_set_expires_range_ns(&rcu_timer, next, rcu_hz_delta_ns);
+	hrtimer_set_expires_range_ns(&rcu_timer, next,
+		rcu_hz_precise ? 0 : rcu_hz_delta_ns);
 	return HRTIMER_RESTART;
 }
 
@@ -539,7 +542,13 @@ static int jrcud_func(void *arg)
 	pr_info("JRCU: daemon started. Will operate at ~%d Hz.\n", rcu_hz);
 
 	while (!kthread_should_stop()) {
-		usleep_range(rcu_hz_period_us, rcu_hz_period_us + rcu_hz_delta_us);
+		if (rcu_hz_precise) {
+			usleep_range(rcu_hz_period_us,
+				rcu_hz_period_us);
+		} else {
+			usleep_range(rcu_hz_period_us,
+				rcu_hz_period_us + rcu_hz_delta_us);
+		}
 		rcu_delimit_batches();
 	}
 
@@ -576,7 +585,9 @@ static int rcu_debugfs_show(struct seq_f
 {
 	int cpu, q;
 
-	seq_printf(m, "%14u: hz\n", rcu_hz);
+	seq_printf(m, "%14u: hz, %s\n",
+		rcu_hz,
+		rcu_hz_precise ? "precise" : "sloppy");
 
 	seq_printf(m, "%14u: watchdog (secs)\n", rcu_wdog_lim / (int)USEC_PER_SEC);
 	seq_printf(m, "%14d: #secs left on watchdog\n",
@@ -686,6 +697,8 @@ next:
 			return -EINVAL;
 		rcu_hz = rcu_hz_wanted;
 		rcu_hz_period_us = USEC_PER_SEC / rcu_hz;
+	} else if (!strncmp(token, "precise=", 8)) {
+		sscanf(&token[8], "%d", &rcu_hz_precise);
 	} else if (!strncmp(token, "wdog=", 5)) {
 		int wdog = -1;
 		sscanf(&token[5], "%d", &wdog);

                 reply	other threads:[~2011-03-24 17:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110324174804.GA18958@tsunami.ccur.com \
    --to=joe.korty@ccur.com \
    --cc=andi@firstfloor.org \
    --cc=dhaval.giani@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=houston.jim@comcast.net \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.minier@linaro.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome