mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Korty <joe.korty@ccur.com>
To: paulmck@linux.vnet.ibm.com
Cc: fweisbec@gmail.com, peterz@infradead.org, laijs@cn.fujitsu.com,
	mathieu.desnoyers@efficios.com, dhowells@redhat.com,
	loic.minier@linaro.org, dhaval.giani@gmail.com,
	tglx@linutronix.de, josh@joshtriplett.org,
	houston.jim@comcast.net, andi@firstfloor.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 23/24] jrcu: better timer slop
Date: Thu, 24 Mar 2011 13:48:04 -0400	[thread overview]
Message-ID: <20110324174804.GA18965@tsunami.ccur.com> (raw)

jrcu: fix broken timer slop

The expression

	USEC_PER_SEC / (HZ * 3 / 2)

was trying to define a period, in usec, some 50% larger
than the natural HZ period.  Instead it made a period
some 30% shorter.

But such attempts are completely unnecessary.  HZ alone
works just fine.

Signed-off-by: Joe Korty <joe.korty@ccur.com>

Index: b/kernel/jrcu.c
===================================================================
--- a/kernel/jrcu.c
+++ b/kernel/jrcu.c
@@ -131,7 +131,7 @@ static struct rcu_stats {
 
 #define RCU_HZ			(20)
 #define RCU_HZ_PERIOD_US	(USEC_PER_SEC / RCU_HZ)
-#define RCU_HZ_DELTA_US		(USEC_PER_SEC / (HZ * 3 / 2))
+#define RCU_HZ_DELTA_US		(USEC_PER_SEC / HZ)
 
 static int rcu_hz = RCU_HZ;
 static int rcu_hz_period_us = RCU_HZ_PERIOD_US;

                 reply	other threads:[~2011-03-24 17:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110324174804.GA18965@tsunami.ccur.com \
    --to=joe.korty@ccur.com \
    --cc=andi@firstfloor.org \
    --cc=dhaval.giani@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=houston.jim@comcast.net \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.minier@linaro.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome