From: Joe Korty <joe.korty@ccur.com>
To: paulmck@linux.vnet.ibm.com
Cc: fweisbec@gmail.com, peterz@infradead.org, laijs@cn.fujitsu.com,
mathieu.desnoyers@efficios.com, dhowells@redhat.com,
loic.minier@linaro.org, dhaval.giani@gmail.com,
tglx@linutronix.de, josh@joshtriplett.org,
houston.jim@comcast.net, andi@firstfloor.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 24/24] jrcu: show #passes affected by NMI
Date: Thu, 24 Mar 2011 13:48:04 -0400 [thread overview]
Message-ID: <20110324174804.GA18972@tsunami.ccur.com> (raw)
jrcu: show #passes affected by NMIs.
If one has a system that generates lots of NMIs, they
may disturb jrcu significantly. It is good to see that
happening in the rcudata file stats.
Signed-off-by: Joe Korty <joe.korty@ccur.com>
Index: b/kernel/jrcu.c
===================================================================
--- a/kernel/jrcu.c
+++ b/kernel/jrcu.c
@@ -122,6 +122,7 @@ static struct rcu_stats {
unsigned npasses; /* #passes made */
unsigned nlast; /* #passes since last end-of-batch */
unsigned nbatches; /* #end-of-batches (eobs) seen */
+ unsigned nmis; /* #passes discarded due to NMI */
atomic_t nbarriers; /* #rcu barriers processed */
atomic_t nsyncs; /* #rcu syncs processed */
u64 ninvoked; /* #invoked (ie, finished) callbacks */
@@ -302,17 +303,20 @@ static void __rcu_delimit_batches(struct
struct rcu_list *plist;
int cpu, eob, prev;
+ if (!rcu_scheduler_active)
+ return;
+
+ rcu_stats.nlast++;
+
/* If an NMI occured then the previous batch may not yet be
* quiescent. Let's wait till it is.
*/
if (rcu_nmi_seen) {
rcu_nmi_seen = 0;
+ rcu_stats.nmis++;
return;
}
- if (!rcu_scheduler_active)
- return;
-
/*
* Find out if the current batch has ended
* (end-of-batch).
@@ -329,8 +333,6 @@ static void __rcu_delimit_batches(struct
}
}
- rcu_stats.nlast++;
-
/*
* Exit if batch has not ended. But first, tickle all non-cooperating
* CPUs if enough time has passed.
@@ -345,7 +347,7 @@ static void __rcu_delimit_batches(struct
}
}
rcu_wdog_ctr += rcu_hz_period_us;
- return eob;
+ return;
}
/*
@@ -603,10 +605,12 @@ static int rcu_debugfs_show(struct seq_f
seq_printf(m, "\n");
seq_printf(m, "%14u: #passes\n",
rcu_stats.npasses);
+ seq_printf(m, "%14u: #passes discarded due to NMI\n",
+ rcu_stats.nmis);
seq_printf(m, "%14u: #passes resulting in end-of-batch\n",
rcu_stats.nbatches);
seq_printf(m, "%14u: #passes not resulting in end-of-batch\n",
- rcu_stats.npasses - rcu_stats.nbatches);
+ rcu_stats.npasses - rcu_stats.nbatches - rcu_stats.nmis);
seq_printf(m, "%14u: #passes since last end-of-batch\n",
rcu_stats.nlast);
seq_printf(m, "%14u: #passes forced (0 is best)\n",
reply other threads:[~2011-03-24 17:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324174804.GA18972@tsunami.ccur.com \
--to=joe.korty@ccur.com \
--cc=andi@firstfloor.org \
--cc=dhaval.giani@gmail.com \
--cc=dhowells@redhat.com \
--cc=fweisbec@gmail.com \
--cc=houston.jim@comcast.net \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.minier@linaro.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome