From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934063Ab1CXT5a (ORCPT ); Thu, 24 Mar 2011 15:57:30 -0400 Received: from adelie.canonical.com ([91.189.90.139]:50222 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933832Ab1CXT50 (ORCPT ); Thu, 24 Mar 2011 15:57:26 -0400 Date: Thu, 24 Mar 2011 14:57:20 -0500 From: Seth Forshee To: Chris Bagwell , Corentin Chary Cc: Matthew Garrett , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] eeepc-wmi: Add support for T101MT "Express Gate" key Message-ID: <20110324195720.GB31713@thinkpad-t410> Mail-Followup-To: Chris Bagwell , Corentin Chary , Matthew Garrett , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <1300909189-4135-1-git-send-email-seth.forshee@canonical.com> <20110324131414.GA20612@thinkpad-t410> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2011 at 09:00:14AM -0500, Chris Bagwell wrote: > On Thu, Mar 24, 2011 at 8:40 AM, Corentin Chary > wrote: > >> I would suggest sending BTN_HOME upon button release 0xe5 (not press > >> 0xe4 and do the autorelease because of it) and BTN_PROG2 on > >> press-and-hold 0xea. > >> > >> If you press-and-hold, does it still send the 0xe5 upon release?  That > >> could complicate things so that both button events do not get sent. > >> > >> I'm not sure what BTN_HOME is commonly used for.  This button does > >> sound like a HOME button in iPad sense but not in web browser sense. > > > > Except the fact that I don't find BTN_HOME in inpout.h, that's seems a > > better idea, forget what I've said earlier. > > Ha... Sorry, I had buttons on my brain. I meant KEY_HOME as you suggested. Really? Isn't KEY_HOME the home key on a standard keyboard? > > 0xe4 -> KEY_IGNORE > > 0xe5 -> KEY_HOME > > 0xea -> KEY_PROG2, (or BTN_TASK to copy android/iOS ?) > > From a quick google, I couldn't finding any specific meaning of > BTN_TASK but it looks like xf86-input-evdev turns it into a button > press so we may not want that one. > > I've no idea of best values but those are pretty close. I'm still not sure what key codes are best either. I've implemented this approach, and I went with BTN_TASK and KEY_PROG2, but I'm getting the idea that BTN_TASK was intended for a mouse button so I'm not really sure if it's a good choice or not. I'll follow up with the patches. Thanks for the feedback so far. Seth