mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Mariusz Kozlowski <mk@lab.zgora.pl>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] cpia2: fix typo in variable initialisation
Date: Sat, 26 Mar 2011 19:28:52 +0100	[thread overview]
Message-ID: <201103261928.52677.hverkuil@xs4all.nl> (raw)
In-Reply-To: <1301163624-7362-1-git-send-email-mk@lab.zgora.pl>

Hi Mariusz,

On Saturday, March 26, 2011 19:20:24 Mariusz Kozlowski wrote:
> Currently 'fh' initialises to whatever happens to be on stack. This
> looks like a typo and this patch fixes that.
> 
> Signed-off-by: Mariusz Kozlowski <mk@lab.zgora.pl>

If you don't mind then I'll take this patch. Although I'll probably drop it,
not because it is wrong as such but because the priority handling in cpia2
is broken big time. I intend to rewrite it using the new prio framework that
was just merged.

Luckily I finally found someone who can test this driver, so that should be
very helpful.

I hope to work on this next weekend.

Regards,

	Hans

> ---
>  drivers/media/video/cpia2/cpia2_v4l.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/cpia2/cpia2_v4l.c b/drivers/media/video/cpia2/cpia2_v4l.c
> index 5111bbc..0073a8c 100644
> --- a/drivers/media/video/cpia2/cpia2_v4l.c
> +++ b/drivers/media/video/cpia2/cpia2_v4l.c
> @@ -1313,7 +1313,7 @@ static int cpia2_g_priority(struct file *file, void *_fh, enum v4l2_priority *p)
>  static int cpia2_s_priority(struct file *file, void *_fh, enum v4l2_priority prio)
>  {
>  	struct camera_data *cam = video_drvdata(file);
> -	struct cpia2_fh *fh = fh;
> +	struct cpia2_fh *fh = _fh;
>  
>  	if (cam->streaming && prio != fh->prio &&
>  			fh->prio == V4L2_PRIORITY_RECORD)
> 

      reply	other threads:[~2011-03-26 18:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-26 18:20 Mariusz Kozlowski
2011-03-26 18:28 ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103261928.52677.hverkuil@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mk@lab.zgora.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®