From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Feng Tang <feng.tang@intel.com>,
Feng Tang <feng.tang@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, "Kp, Jeeja" <jeeja.kp@intel.com>,
"Fu, Michael" <michael.fu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Wu, Fengguang" <fengguang.wu@intel.com>,
"meego-kernel@lists.meego.com" <meego-kernel@lists.meego.com>
Subject: Re: [Meego-kernel] [PATCH v9 1/2] mrst: export get_gpio_by_name() function
Date: Mon, 28 Mar 2011 10:46:15 +0100 [thread overview]
Message-ID: <20110328104615.52c6c03c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4D8FF9E5.8000502@linux.intel.com>
> Medfield and MRST are targeting phones. MIDs don't exist... not in this
> decade.
Well you can take that up with everyone else somewhere offlist, but the
standard naming being used for these devices as a group is mid_xxx, and
has been in the kernel several releases.
> if it was renamed to sfi_get_gpio_by_name() it might make SOME sense,
> but even then it's a
> gratuitous rename for a function that's already in the upstream kernel.
1. It needs a name that won't clash with anything else or confuse people
2. It shouldn't be exported in the first place but appearing in the PCI
data for the device.
If it must be exported then it definitely needs a rename.
next prev parent reply other threads:[~2011-03-28 9:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1301279360-9839-1-git-send-email-guanqun.lu@intel.com>
2011-03-28 2:29 ` Lu Guanqun
2011-03-28 2:34 ` Arjan van de Ven
2011-03-28 2:47 ` Feng Tang
2011-03-28 2:47 ` Arjan van de Ven
2011-03-28 2:59 ` Lu Guanqun
2011-03-28 3:00 ` Feng Tang
2011-03-28 3:00 ` [Meego-kernel] " Arjan van de Ven
2011-03-28 3:12 ` Feng Tang
2011-03-28 9:46 ` Alan Cox [this message]
2011-03-28 5:50 ` Greg KH
2011-03-28 6:25 ` Feng Tang
2011-03-28 2:29 ` [PATCH v9 2/2] sst: internal speaker needs setting a GPIO line Lu Guanqun
2011-03-28 2:35 ` Arjan van de Ven
2011-03-28 2:53 ` Lu Guanqun
2011-03-28 3:19 ` Jeff_Cheng
2011-03-28 5:51 ` Greg KH
2011-03-28 16:18 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328104615.52c6c03c@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=arjan@linux.intel.com \
--cc=feng.tang@intel.com \
--cc=feng.tang@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=jeeja.kp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meego-kernel@lists.meego.com \
--cc=michael.fu@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®