From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Jens Axboe <jaxboe@fusionio.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] block drivers for 2.6.39-rc
Date: Mon, 28 Mar 2011 16:08:12 +1100 [thread overview]
Message-ID: <20110328160812.b4d19eb5.sfr@canb.auug.org.au> (raw)
In-Reply-To: <AANLkTik3GZ0b5S7p4ONQu4Hb8LoKewmMJ7_J5zvumYD-@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]
Hi Linus, Ingo,
On Sun, 27 Mar 2011 21:37:50 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Sun, Mar 27, 2011 at 9:23 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > This driver does not build at all:
> >
> > drivers/block/drbd/drbd_bitmap.c:1187:5: error: implicit declaration of function ‘generic_find_next_zero_le_bit’ [-Werror=implicit-function-declaration]
> > drivers/block/drbd/drbd_bitmap.c:1190:5: error: implicit declaration of function ‘generic_find_next_le_bit’ [-Werror=implicit-function-declaration]
> > drivers/block/drbd/drbd_bitmap.c:1290:4: error: implicit declaration of function ‘generic___test_and_set_le_bit’ [-Werror=implicit-function-declaration]
> > drivers/block/drbd/drbd_bitmap.c:1292:4: error: implicit declaration of function ‘generic___test_and_clear_le_bit’ [-Werror=implicit-function-declaration]
> > drivers/block/drbd/drbd_bitmap.c:1441:3: error: implicit declaration of function ‘generic_test_le_bit’ [-Werror=implicit-function-declaration]
> >
> > Has this been build-tested? These APIs do not exist upstream.
>
> Actually, I think that's just a merge error - those horrible nasty
> crazy names did use to exist.
>
> Does this fix it? (Untested!)
You also need to remove the include of asm-generic/bitops/le.h from that
file now (the easiest way is to revert commit f0ff1357ce39 ("drbd: need
include for bitops functions declarations").
Jens was informed about these problems when they appeared in linux-next.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-03-28 5:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 18:56 Jens Axboe
2011-03-28 4:23 ` Ingo Molnar
2011-03-28 4:37 ` Linus Torvalds
2011-03-28 4:43 ` Ingo Molnar
2011-03-28 5:08 ` Stephen Rothwell [this message]
2011-03-28 6:43 ` Jens Axboe
2011-03-28 7:04 ` Stephen Rothwell
2011-03-28 7:21 ` Jens Axboe
2011-03-28 23:06 ` Linus Torvalds
2011-03-29 6:34 ` Jens Axboe
2011-03-29 13:18 ` scameron
2011-03-29 11:17 ` [sporadic crash] blk: request botched Ingo Molnar
2011-03-29 11:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328160812.b4d19eb5.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®