From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754528Ab1C1PQO (ORCPT ); Mon, 28 Mar 2011 11:16:14 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:49848 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753715Ab1C1PQN (ORCPT ); Mon, 28 Mar 2011 11:16:13 -0400 Date: Mon, 28 Mar 2011 16:16:22 +0100 From: Alan Cox To: Anithra P Janakiraman Cc: linux-kernel@vger.kernel.org, dave@linux.vnet.ibm.com, xiyou.wangcong@gmail.com, sugaken.r3@gmail.com, akpm@linux-foundation.org, vatsa@linux.vnet.ibm.com, ananth@in.ibm.com Subject: Re: [RESEND] [PATCH] Softdog enhancement to optionally invoke panic instead of reboot on timer expiry Message-ID: <20110328161622.100e3a51@lxorguk.ukuu.org.uk> In-Reply-To: <20110328203502.5d62fea4@linux.vnet.ibm.com> References: <20110328203502.5d62fea4@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Mar 2011 20:35:02 +0530 Anithra P Janakiraman wrote: > Hi, > > The patch is needed for determining the reason for failure when a > softdog timeout occurs. We use softdog to watch for critical > application failures and at the minimum a snapshot of the system would > help to determine the cause. In such a scenario the application could > fail but there isn't a softlockup as such, hence the detect softlockup > feature does not help. The patch below adds a module parameter > soft_panic which when set to 1 causes softdog to invoke panic instead > of reboot when the softdog timer expires. By invoking panic we execute > kdump if it is configured and the vmcore generated by kdump should > provide atleast a minimal idea of the reason for failure. Looks sensible to me. Acked-by: Alan Cox Alan