From: Wolfram Sang <w.sang@pengutronix.de>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Hillf Danton <dhillf@gmail.com>, Greg KH <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] uio: fix allocating minor id for uio device
Date: Tue, 29 Mar 2011 10:40:55 +0200 [thread overview]
Message-ID: <20110329084055.GB2901@pengutronix.de> (raw)
In-Reply-To: <20110328214504.GC2786@local>
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
> > - idev->minor = id & MAX_ID_MASK;
> > + if (id < UIO_MAX_DEVICES)
> > + idev->minor = id;
> > + else {
As it needs respinning anyway: If the else-block has braces, it is
recommended for the if-block, too
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-03-29 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 8:00 Hillf Danton
2011-03-28 21:45 ` Hans J. Koch
2011-03-29 8:40 ` Wolfram Sang [this message]
2011-03-31 12:38 ` Hillf Danton
2011-03-31 17:55 ` Hans J. Koch
-- strict thread matches above, loose matches on Subject: below --
2011-03-27 7:22 zhdxzx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329084055.GB2901@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=dhillf@gmail.com \
--cc=gregkh@suse.de \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®