From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553Ab1C2Kml (ORCPT ); Tue, 29 Mar 2011 06:42:41 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56018 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353Ab1C2Kmk (ORCPT ); Tue, 29 Mar 2011 06:42:40 -0400 Date: Tue, 29 Mar 2011 12:42:31 +0200 From: Wolfram Sang To: "vooon341@gmail.com" Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Ball , Andrew Morton Subject: Re: [PATCH] mmc: Add MPC512x SDHC driver. Message-ID: <20110329104231.GB18155@pengutronix.de> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XOIedfhf+7KOe/yw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:221:70ff:fe71:1890 X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XOIedfhf+7KOe/yw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Vladimir, > MPC512x have similar sdhc module as in MX2/MX3, > but use different access to the registers. There are quite some drivers abstracting the register-access (sdhci-esdhc for example which is also used on ppc and arm). If the state-machine is the same, this really should be done. Otherwise maintenance will be harder. I have mx2/3-hardware here and am willing to test the changes. If the state-machine is significantly different, a seperate driver makes sense, of course. Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --XOIedfhf+7KOe/yw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk2Rt5cACgkQD27XaX1/VRupZQCfZBKjZDcAXYpWruv/YddLcrl6 5l4AnigRQQhsiy7kyVpMGYYDvtdlzziJ =fihf -----END PGP SIGNATURE----- --XOIedfhf+7KOe/yw--