mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pete Clements <clem@clem.clem-digital.net>
To: jaxboe@fusionio.com (Jens Axboe)
Cc: rlandley@parallels.com (Rob Landley),
	linux-kernel@vger.kernel.org (linux-kernel),
	linux-ide@vger.kernel.org (linux-ide@vger.kernel.org)
Subject: Re: Commit 7eaceaccab5f40 causing boot hang.
Date: Tue, 29 Mar 2011 11:51:13 -0400 (EDT)	[thread overview]
Message-ID: <201103291551.p2TFpDqZ001692@clem.clem-digital.net> (raw)
In-Reply-To: <4D91E9DA.4050504@fusionio.com>

Quoting Jens Axboe
  > 
  > On 2011-03-29 16:13, Rob Landley wrote:
  > > On 03/29/2011 08:59 AM, Jens Axboe wrote:
  > >> On 2011-03-29 10:52, Rob Landley wrote:
  > >>> I'm booting all this under kvm or qemu, by the way:
  > >>>
  > >>> qemu-system-x86_64 -m 1024 -kernel arch/x86/boot/bzImage \
  > >>>   -hda ~/sid.ext3 -append "root=/dev/hda rw"
  > >>>
  > >>> Sometimes with init=/bin/bash in that last quoted bit.  The root
  > >>> filesystem's debian sid but that's probably not relevant because it
  > >>> worked fine with .38.
  > >>
  > >> Does this help?
  > >>
  > >> diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
  > >> index 0e406d73..ca27d30 100644
  > >> --- a/drivers/ide/ide-io.c
  > >> +++ b/drivers/ide/ide-io.c
  > >> @@ -570,8 +570,7 @@ void ide_requeue_and_plug(ide_drive_t *drive, struct request *rq)
  > >>  	spin_unlock_irqrestore(q->queue_lock, flags);
  > >>  
  > >>  	/* Use 3ms as that was the old plug delay */
  > >> -	if (rq)
  > >> -		blk_delay_queue(q, 3);
  > >> +	blk_delay_queue(q, 3);
  > >>  }
  > >>  
  > >>  static int drive_is_ready(ide_drive_t *drive)
  > >>
  > > 
  > > Nope, still hung the same way.
  > 
  > Funky. I'll try and reproduce this tonight.
  > 
  > -- 
  > Jens Axboe
  > 

I have had a similiar problem (reported earlier) unable to boot.
With git15-18 hung with IDE drives (hda), git19-21 moved the hang down to
the IDE CDROM (hdc). Applied the above patch and now booted into git21 without
any hang and all appears ok.  This is i386, UP. 

--
Pete Clements

  reply	other threads:[~2011-03-29 15:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29  6:19 Rob Landley
2011-03-29  6:35 ` Jens Axboe
2011-03-29  8:52   ` Rob Landley
2011-03-29 13:59     ` Jens Axboe
2011-03-29 14:13       ` Rob Landley
2011-03-29 14:16         ` Jens Axboe
2011-03-29 15:51           ` Pete Clements [this message]
2011-03-30  6:06             ` Rob Landley
2011-03-30 11:38               ` Jens Axboe
2011-03-30 13:52                 ` Rob Landley
2011-03-31  9:02                   ` Jens Axboe
2011-03-31  9:11                     ` Rob Landley
2011-03-31 10:07                       ` Jens Axboe
2011-03-31 10:37                         ` Jens Axboe
2011-03-31 10:47                           ` Rob Landley
2011-03-31 11:09                             ` Jens Axboe
2011-04-01  3:11                               ` Nicholas A. Bellinger
2011-04-03  7:05                                 ` Andreas Mohr
2011-04-01 12:26                               ` Mark Lord
2011-04-09  2:56                               ` Rob Landley
2011-04-09  3:00                                 ` Jens Axboe
2011-03-31 12:11                           ` Tejun Heo
2011-03-31 12:33                             ` Jens Axboe
2011-03-31 13:09                               ` Richard Kennedy
2011-03-31 13:18                                 ` Jens Axboe
2011-03-31 13:23                                   ` Richard Kennedy
2011-03-31 13:33                                     ` Jens Axboe
2011-03-31 14:49                                       ` Richard Kennedy
2011-04-04 13:47                                         ` Richard Kennedy
2011-04-13 10:25                                           ` Richard Kennedy
2011-04-13 10:36                                             ` Jens Axboe
2011-04-06 11:55                               ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103291551.p2TFpDqZ001692@clem.clem-digital.net \
    --to=clem@clem.clem-digital.net \
    --cc=jaxboe@fusionio.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rlandley@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®