From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: merging discard request in the block layer
Date: Wed, 30 Mar 2011 10:16:26 -0400 [thread overview]
Message-ID: <20110330141626.GA17914@infradead.org> (raw)
In-Reply-To: <4D890EBD.1090103@fusionio.com>
On Tue, Mar 22, 2011 at 10:03:57PM +0100, Jens Axboe wrote:
> On 2011-03-22 20:54, Jens Axboe wrote:
> > On 2011-03-22 20:47, Christoph Hellwig wrote:
> >> It seems the current block layer wil happily try to merge discard
> >> requests that were split because they are at the max that bi_size
> >> can hold together again. At least that's what the
> >>
> >> blk: request botched
> >
> > That would seem to indicate a bug in the merging logic instead.
>
> What kind of max discard size does you device have? If the max discard
> size is smaller than the regular request size, this could help.
I've done some heavier test, and both the extended check for mergeable
requests or your patch with different limits hangs the test box hard
with no way to get a backtrace. Using my original patch to completely
skip the merging logic seems to work fine.
next prev parent reply other threads:[~2011-03-30 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 19:47 Christoph Hellwig
2011-03-22 19:54 ` Jens Axboe
2011-03-22 21:00 ` Christoph Hellwig
2011-03-22 21:03 ` Jens Axboe
2011-03-23 13:01 ` Christoph Hellwig
2011-03-23 15:26 ` Jens Axboe
2011-03-30 14:16 ` Christoph Hellwig [this message]
2011-05-03 18:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330141626.GA17914@infradead.org \
--to=hch@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome