From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
platform-driver-x86@vger.kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>,
"Lee, Chun-Yi" <jlee@novell.com>
Subject: [PATCH -rc1] msi-laptop: fix config-dependent build error
Date: Wed, 30 Mar 2011 15:20:22 -0700 [thread overview]
Message-ID: <20110330152022.9b3e6942.randy.dunlap@oracle.com> (raw)
In-Reply-To: <AANLkTikwbY5mm10ZWg7B6XeSBkZXFqKcYVZfJCi2QGx_@mail.gmail.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
The msi-laptop driver uses input_*() and sparse_keymap_*() interfaces.
It should depend on the INPUT subsystem being present and select
INPUT_SPARSEKMAP so that those interfaces are present.
ERROR: "input_free_device" [drivers/platform/x86/msi-laptop.ko] undefined!
ERROR: "input_register_device" [drivers/platform/x86/msi-laptop.ko] undefined!
ERROR: "sparse_keymap_setup" [drivers/platform/x86/msi-laptop.ko] undefined!
ERROR: "input_allocate_device" [drivers/platform/x86/msi-laptop.ko] undefined!
ERROR: "sparse_keymap_report_event" [drivers/platform/x86/msi-laptop.ko] undefined!
ERROR: "input_unregister_device" [drivers/platform/x86/msi-laptop.ko] undefined!
ERROR: "sparse_keymap_free" [drivers/platform/x86/msi-laptop.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: "Lee, Chun-Yi" <jlee@novell.com>
---
drivers/platform/x86/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- lnx-2639-rc1.orig/drivers/platform/x86/Kconfig
+++ lnx-2639-rc1/drivers/platform/x86/Kconfig
@@ -187,7 +187,8 @@ config MSI_LAPTOP
depends on ACPI
depends on BACKLIGHT_CLASS_DEVICE
depends on RFKILL
- depends on SERIO_I8042
+ depends on INPUT && SERIO_I8042
+ select INPUT_SPARSEKMAP
---help---
This is a driver for laptops built by MSI (MICRO-STAR
INTERNATIONAL):
next prev parent reply other threads:[~2011-03-30 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 21:07 Merge window closed - 2.6.39-rc1 out Linus Torvalds
2011-03-30 12:01 ` Christoph Hellwig
2011-03-30 14:43 ` Konrad Rzeszutek Wilk
2011-03-30 15:05 ` Konrad Rzeszutek Wilk
2011-03-30 22:29 ` Christoph Hellwig
2011-04-01 13:17 ` Konrad Rzeszutek Wilk
2011-03-30 22:20 ` Randy Dunlap [this message]
2011-03-31 6:41 ` [PATCH -rc1] msi-laptop: fix config-dependent build error Joey Lee
2011-04-01 18:21 ` Matthew Garrett
2011-03-31 2:17 ` Merge window closed - 2.6.39-rc1 out Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330152022.9b3e6942.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jlee@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome