From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932886Ab1C3UCq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Mar 2011 16:02:46 -0400
Received: from mail-iy0-f174.google.com ([209.85.210.174]:33583 "EHLO
	mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754847Ab1C3UCp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Mar 2011 16:02:45 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=lzP+wB3cJi+tyu3qJUn//zylqt9+FIDS1tSjbyXjtWvsk3ya/kYheLMnkTxcJYkFsT
         Gk/MPQRsFWFx6EDN2FAVhK08teXx0GLlEfw0HtaxoEEfbDqKa4mSDOkoCfDdUpXcP+m6
         l4ru79Q2QU+n+u1B8UCnkTIAWYjMVY6RKucAg=
Date: Wed, 30 Mar 2011 13:02:38 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Christopher Heiny <cheiny@synaptics.com>
Cc: Jean Delvare <khali@linux-fr.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Linux Input <linux-input@vger.kernel.org>,
        Allie Xiong <axiong@synaptics.com>,
        William Manson <wmanson@synaptics.com>,
        Joerie de Gram <j.de.gram@gmail.com>,
        Linus Walleij <linus.walleij@stericsson.com>,
        Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>
Subject: Re: [PATCH 0/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver
Message-ID: <20110330200238.GA9493@core.coreip.homeip.net>
References: <1301493927-30237-1-git-send-email-cheiny@synaptics.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1301493927-30237-1-git-send-email-cheiny@synaptics.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Chris,

On Wed, Mar 30, 2011 at 07:05:24AM -0700, Christopher Heiny wrote:
> This patch implements a driver supporting Synaptics ClearPad and other
> touchscreens that use the RMI4 protocol, as defined here:
> 
>     http://www.synaptics.com/sites/default/files/511-000136-01_revD.pdf
> 
> This patch is against the v2.6.38 tag of Linus' kernel tree, commit
> 521cb40b0c44418a4fd36dc633f575813d59a43d.  Note that previous patches
> were against the synaptics-rmi4 branch of Dmitry Torokhov's input
> tree.  At Dmitry's request, we have switched the base for our work
> to v2.6.38 - this should make it easier for people to pick up and
> test this and future patches.
> 

The source as sumitted is quite "dirty" i.e. littered with multiple #if
0...#endif etc. Cooudl you please clean it up and resubmit so that
unneeded details/code would not get into the way of reviiewing the
driver?

Thanks.

-- 
Dmitry