From: Dave Chinner <david@fromorbit.com>
To: Sage Weil <sage@newdream.net>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, mszeredi@suse.cz
Subject: Re: [PATCH 4/7] vfs: push dentry_unhash on rename_dir into file systems
Date: Thu, 31 Mar 2011 14:09:26 +1100 [thread overview]
Message-ID: <20110331030926.GB30279@dastard> (raw)
In-Reply-To: <1301522968-4382-5-git-send-email-sage@newdream.net>
On Wed, Mar 30, 2011 at 03:09:25PM -0700, Sage Weil wrote:
> Only a few file systems need this. Start by pushing it down into each
> rename method so that it can be dealt with on a per-fs basis.
What is the criteria for a filesystem needing this?
> Signed-off-by: Sage Weil <sage@newdream.net>
> ---
> fs/9p/vfs_inode.c | 3 +++
> fs/affs/namei.c | 3 +++
> fs/afs/dir.c | 3 +++
> fs/bfs/dir.c | 3 +++
> fs/btrfs/inode.c | 3 +++
> fs/ceph/dir.c | 3 +++
> fs/cifs/inode.c | 3 +++
> fs/coda/dir.c | 3 +++
> fs/ecryptfs/inode.c | 3 +++
> fs/exofs/namei.c | 3 +++
> fs/ext2/namei.c | 3 +++
> fs/ext3/namei.c | 3 +++
> fs/ext4/namei.c | 3 +++
> fs/fat/namei_msdos.c | 3 +++
> fs/fat/namei_vfat.c | 3 +++
> fs/fuse/dir.c | 4 ++++
> fs/gfs2/ops_inode.c | 3 +++
> fs/hfs/dir.c | 3 +++
> fs/hostfs/hostfs_kern.c | 3 +++
> fs/hpfs/namei.c | 4 ++++
> fs/jffs2/dir.c | 3 +++
> fs/jfs/namei.c | 3 +++
> fs/libfs.c | 3 +++
> fs/logfs/dir.c | 3 +++
> fs/minix/namei.c | 3 +++
> fs/namei.c | 5 +----
> fs/ncpfs/dir.c | 3 +++
> fs/nfs/dir.c | 3 +++
> fs/nilfs2/namei.c | 3 +++
> fs/ocfs2/namei.c | 3 +++
> fs/omfs/dir.c | 3 +++
> fs/reiserfs/namei.c | 3 +++
> fs/sysv/namei.c | 3 +++
> fs/ubifs/dir.c | 3 +++
> fs/udf/namei.c | 3 +++
> fs/ufs/namei.c | 3 +++
> 36 files changed, 108 insertions(+), 4 deletions(-)
You didn't push it down into XFS, hence my question....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2011-03-31 3:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 22:09 [PATCH 0/7] Do not dentry_unhash() in VFS Sage Weil
2011-03-30 22:09 ` [PATCH 1/7] vfs: dentry_unhash immediately prior to rmdir Sage Weil
2011-03-30 22:09 ` [PATCH 2/7] vfs: remove dget() from dentry_unhash() Sage Weil
2011-03-30 22:09 ` [PATCH 3/7] vfs: push dentry_unhash on rmdir into file systems Sage Weil
2011-03-30 22:09 ` [PATCH 4/7] vfs: push dentry_unhash on rename_dir " Sage Weil
2011-03-31 3:09 ` Dave Chinner [this message]
2011-03-31 4:40 ` Sage Weil
2011-03-30 22:09 ` [PATCH 5/7] vfs: update dentry_unhash() comment Sage Weil
2011-03-30 22:09 ` [PATCH 6/7] libfs: drop unneeded dentry_unhash Sage Weil
2011-03-30 22:09 ` [PATCH 7/7] vfs: fix vfs_rename_dir for FS_RENAME_DOES_D_MOVE filesystems Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331030926.GB30279@dastard \
--to=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=sage@newdream.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®