From: Florian Mickler <florian@mickler.org>
To: Florian Mickler <florian@mickler.org>
Cc: stable@kernel.org, linux-kernel@vger.kernel.org, "Lee,
Chun-Yi" <joeyli.kernel@gmail.com>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
Matthew Garrett <mjg@redhat.com>, Dmitry Torokhov <dtor@mail.ru>,
Corentin Chary <corentincj@iksaif.net>,
Johannes Berg <johannes@sipsolutions.net>,
"Lee, Chun-Yi" <jlee@novell.com>
Subject: Re: [PATCH] acer-wmi: does not set persistence state by rfkill_init_sw_state
Date: Thu, 31 Mar 2011 10:30:54 +0200 [thread overview]
Message-ID: <20110331103054.73438ab5@schatten.dmk.lab> (raw)
In-Reply-To: <1301516277-1752-1-git-send-email-florian@mickler.org>
On Wed, 30 Mar 2011 22:17:57 +0200
Florian Mickler <florian@mickler.org> wrote:
> From: Lee, Chun-Yi <joeyli.kernel@gmail.com>
>
> Acer BIOS keeps devices state when system reboot, but reset to default
> device states (Wlan on, Bluetooth off, wwan on) if system cold boot.
> That means BIOS's initial state is not always real persistence.
>
> So, removed rfkill_init_sw_state because it sets initial state to
> persistence then replicate to other new killswitch when rfkill-input
> enabled.
> After removed it, acer-wmi set initial soft-block state after rfkill
> register, and doesn't allow set_block until rfkill initial finished.
>
> Reference: bko#31002
> https://bugzilla.kernel.org/show_bug.cgi?id=31002
>
> Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Cc: Corentin Chary <corentincj@iksaif.net>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> Tested-by: OldÅich JedliÄka <oldium.pro@seznam.cz>
> Signed-off-by: Florian Mickler <florian@mickler.org>
> ---
>
> This fixes a regression, but no stable annotation was given...
>
> Oversight? Matthew/Chun-Yi please take a look.
>
I forgot: This is upstream
commit 8215af019040ce9182728afee9642d8fdeb17f59 .
As for the Tested-by:, I think that's borked in git. At least I can't
get it out of git correctly. It should be:
Tested-by: Oldřich Jedlička <oldium.pro@seznam.cz>
Thanks,
Flo
next prev parent reply other threads:[~2011-03-31 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 20:17 Florian Mickler
2011-03-30 20:22 ` Johannes Berg
2011-03-30 21:19 ` Florian Mickler
2011-03-31 8:30 ` Florian Mickler [this message]
2011-03-31 8:49 ` Joey Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331103054.73438ab5@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=carlos@strangeworlds.co.uk \
--cc=corentincj@iksaif.net \
--cc=dtor@mail.ru \
--cc=jlee@novell.com \
--cc=joeyli.kernel@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome