From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Cc: Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] vt: avoid BUG_ON in con_shutdown when con_open returns with error
Date: Thu, 31 Mar 2011 15:52:22 +0100 [thread overview]
Message-ID: <20110331155222.061f9c9f@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110331133725.GA2040@herton-IdeaPad-Y430>
> I still wonder though if really the BUG_ON is ok, or I still didn't got
> that code right. Even if it returns -ERESTARTSYS we will hit that
> BUG_ON, if vc->port.tty != tty no? Or that is what the BUG_ON is trying
> to catch?
The code is trying to trap a locking error on hangup cases I think.
Although the console code currently handles this via its own different
locking so is a bit of a mess - it wants moving to the tty kref stuff
properly but thats not yet been done.
> While looking I noted a minor thing, in tty_open we don't need to check
> retval again in one place, as !retval is always true, because we return
> earlier (in retval = tty_add_file ...):
Agreed - that change
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2011-03-31 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 22:29 Herton Ronaldo Krzesinski
2011-03-31 9:58 ` Alan Cox
2011-03-31 13:37 ` Herton Ronaldo Krzesinski
2011-03-31 14:52 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331155222.061f9c9f@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=herton.krzesinski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®