From: Ingo Molnar <mingo@elte.hu>
To: Florian Mickler <florian@mickler.org>
Cc: linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
kurup_avinash@yahoo.com, maciej.rutecki@gmail.com, rjw@sisk.pl,
sedat.dilek@gmail.com, stable@kernel.org, #.34+@schatten.dmk.lab
Subject: Re: [PATCH v2] x86, ioapic: Skip looking for ioapic overrides when ioapics are not present
Date: Fri, 1 Apr 2011 08:20:06 +0200 [thread overview]
Message-ID: <20110401062006.GC32378@elte.hu> (raw)
In-Reply-To: <1301621025-3858-1-git-send-email-florian@mickler.org>
* Florian Mickler <florian@mickler.org> wrote:
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -3789,6 +3789,10 @@ int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity)
> {
> int ioapic, pin, idx;
>
> +#ifdef CONFIG_ACPI
> + if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
> + return -1;
> +#endif
That #ifdef is very ugly. Please introduce a suitable helper function in
arch/x86/include/asm/acpi.h - acpi_irq_ioapic_model() or so, which could be
used like this:
if (!acpi_irq_ioapic_model())
return -1;
And would be defined in the !CONFIG_ACPI case as well.
Thanks,
Ingo
next prev parent reply other threads:[~2011-04-01 6:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 8:01 [PATCH][POKE] " Florian Mickler
2011-03-31 8:43 ` Ingo Molnar
2011-03-31 10:59 ` Florian Mickler
2011-04-02 15:11 ` [stable] " Andi Kleen
2011-04-02 18:35 ` Ingo Molnar
2011-04-01 1:23 ` [PATCH v2] x86, ioapic: " Florian Mickler
2011-04-01 6:20 ` Ingo Molnar [this message]
2011-04-01 6:43 ` Eric W. Biederman
2011-04-01 6:47 ` Len Brown
2011-04-01 7:50 ` Ingo Molnar
2011-04-01 15:44 ` [PATCH] x86, ioapic: move acpi_get_override_irq to acpi.c Florian Mickler
2011-04-01 16:26 ` Florian Mickler
2011-04-03 14:34 ` Florian Mickler
2011-04-04 15:00 ` Ingo Molnar
2011-04-12 7:39 ` Ingo Molnar
2011-04-12 19:53 ` Florian Mickler
2011-04-12 20:01 ` [PATCH 1/2 v2] x86, ioapic: Skip looking for ioapic overrides when ioapics are not present Florian Mickler
2011-04-12 20:01 ` [PATCH 2/2 v2] x86, ioapic: move acpi_get_override_irq to acpi.c Florian Mickler
2011-04-15 10:19 ` Ingo Molnar
2011-05-17 14:38 ` Florian Mickler
2011-03-31 8:48 ` [PATCH][POKE] Skip looking for ioapic overrides when ioapics are not present Paul Bolle
2011-03-31 10:53 ` Florian Mickler
2011-03-31 11:01 ` Sedat Dilek
2011-03-31 12:05 ` Eric W. Biederman
2011-03-31 12:43 ` Ingo Molnar
2011-04-02 0:48 ` Eric W. Biederman
2011-04-02 18:43 ` Ingo Molnar
2011-04-02 22:21 ` Eric W. Biederman
2011-03-31 13:16 ` Florian Mickler
2011-03-31 13:25 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110401062006.GC32378@elte.hu \
--to=mingo@elte.hu \
--cc=#.34+@schatten.dmk.lab \
--cc=ebiederm@xmission.com \
--cc=florian@mickler.org \
--cc=kurup_avinash@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=rjw@sisk.pl \
--cc=sedat.dilek@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome