From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757830Ab1DAPSw (ORCPT ); Fri, 1 Apr 2011 11:18:52 -0400 Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]:37658 "EHLO na3sys009aog102.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757193Ab1DAPSv (ORCPT ); Fri, 1 Apr 2011 11:18:51 -0400 Date: Fri, 1 Apr 2011 18:18:44 +0300 From: Felipe Balbi To: Axel Lin Cc: linux-kernel@vger.kernel.org, David Brownell , Dmitry Torokhov , linux-input@vger.kernel.org Subject: Re: [PATCH] Input: twl4030_keypad - fix potential NULL dereference in twl4030_kp_probe() Message-ID: <20110401151843.GB2164@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <1301670483.6013.4.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1301670483.6013.4.camel@phoenix> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 01, 2011 at 11:08:03PM +0800, Axel Lin wrote: > We should first check whether platform data is NULL or not, before > dereferencing it to get the keymap. > > Signed-off-by: Axel Lin Reviewed-by: Felipe Balbi -- balbi