Re: [PATCH] arm: nomadik: avoid assigning u32 to bool

[Nicolas Kaiser <nikai@nikai.net>]

* Rabin Vincent <rabin@rab.in>:
> On Sat, Apr 2, 2011 at 03:21, Nicolas Kaiser <nikai@nikai.net> wrote:
> > Avoid assigning u32 to the bool 'enabled'.
> >
> > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> > ---
> >  arch/arm/plat-nomadik/gpio.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/plat-nomadik/gpio.c b/arch/arm/plat-nomadik/gpio.c
> > index f49748e..8b722f7 100644
> > --- a/arch/arm/plat-nomadik/gpio.c
> > +++ b/arch/arm/plat-nomadik/gpio.c
> > @@ -636,7 +636,7 @@ static int nmk_gpio_irq_set_type(struct irq_data *d, unsigned int type)
> >        if (type & IRQ_TYPE_LEVEL_LOW)
> >                return -EINVAL;
> >
> > -       enabled = nmk_chip->enabled & bitmask;
> > +       enabled = !!(nmk_chip->enabled & bitmask);
> 
> Why?  There are dozens of places in the kernel where this done, the code
> generated should be the same, and it's pretty obvious what is being done
> as it is.

Primarily because we were asked to avoid casts to bool even if
they are safe.
https://lkml.org/lkml/2011/4/1/255

Besides, many of the places I found that do 'bool a = b & c;'
actually do 'bool a = b & 1;'.

Best regards,
Nicolas Kaiser