From: Antonio Ospite <ospite@studenti.unina.it>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [PATCH 7/8] Documentation: consolidate leds files to leds/ subdir
Date: Tue, 5 Apr 2011 10:25:40 +0200 [thread overview]
Message-ID: <20110405102540.091ec116.ospite@studenti.unina.it> (raw)
In-Reply-To: <BANLkTikSbTgsH1zHm+mEu6C3R5dEsw2ogA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Mon, 4 Apr 2011 17:54:04 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, Apr 4, 2011 at 3:08 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> >
> > Changes since v1:
> > - don't use git renames
>
> Actually, I think it would make it much easier to validate the patches
> if you used git rename patches for things like this.
>
I agree, and I did that for the first review round.
Initially the patch was meant to be handled by Andrew Morton, maybe I
misunderstood one of his comments from
http://www.spinics.net/lists/linux-doc/msg02562.html :
"hm, these look like funky git renames. patch(1) doesn't
handle those."
and though he wanted me to change that.
> As a traditional patch, it's impossible to see that "yes, it's a
> rename". There might be tons of changes hiding in the add/remove pair.
>
> Linus
>
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-04-05 8:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 21:58 [PATCH 1/8] Documentation: update kmemleak arch. info Randy Dunlap
2011-04-04 21:59 ` [PATCH 2/8] kernel/signal.c: fix typos and coding style Randy Dunlap
2011-04-04 22:00 ` [PATCH 3/8] kernel/signal.c: add kernel-doc notation to syscalls Randy Dunlap
2011-04-05 8:32 ` Matt Fleming
2011-04-08 17:41 ` Randy Dunlap
2011-04-08 17:53 ` [PATCH] signal.c: fix erroneous syscall kernel-doc Randy Dunlap
2011-04-08 20:13 ` Matt Fleming
2011-04-04 22:02 ` [PATCH 4/8] Documentation: update panic parameter info Randy Dunlap
2011-04-04 22:04 ` [PATCH 5/8] Documentation: fix minor typos/spelling Randy Dunlap
2011-04-04 22:06 ` [PATCH 6/8] kemleak-test: build as module only Randy Dunlap
2011-04-04 22:08 ` [PATCH 7/8] Documentation: consolidate leds files to leds/ subdir Randy Dunlap
2011-04-05 0:54 ` Linus Torvalds
2011-04-05 8:25 ` Antonio Ospite [this message]
2011-04-04 22:10 ` [PATCH 8/8] Documentation: update cgroups info user groups names Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405102540.091ec116.ospite@studenti.unina.it \
--to=ospite@studenti.unina.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=richard.purdie@linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®