From: jacob pan <jacob.jun.pan@linux.intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Feng Tang <feng.tang@intel.com>, Alan Cox <alan@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH v2] x86/mrst: correct pin to irq mapping
Date: Mon, 11 Apr 2011 09:43:30 -0700 [thread overview]
Message-ID: <20110411094330.69c86910@jacob-laptop> (raw)
In-Reply-To: <20110410060154.GA24684@elte.hu>
On Sun, 10 Apr 2011 08:01:54 +0200
Ingo Molnar <mingo@elte.hu> wrote:
>
> * Jacob Pan <jacob.jun.pan@linux.intel.com> wrote:
>
> > As a result, apbt timer and RTC interrupts on Moorestown are within
> > legacy IRQ range.
> >
> > sh-3.2# cat /proc/interrupts
> > CPU0 CPU1
> > 0: 11249 0 IO-APIC-edge apbt0
> > 1: 0 12271 IO-APIC-edge apbt1
> > 8: 887 0 IO-APIC-fasteoi dw_spi
> > 13: 0 0 IO-APIC-fasteoi INTEL_MID_DMAC2
> > 14: 0 0 IO-APIC-fasteoi rtc0
>
> Is there a 'before the patch' /proc/interrupts output as well?
> Supposedly it's different and seeing that different output is *way*
> more descriptive to the casual commit log reader than a textual
> explanation only.
>
If v1 patch is used, /proc/interrupts look like below on Moorestown.
Notice that apbt1 interrupts is moved to gsi_top + 1 = 39.
bash-3.2# cat /proc/interrupts
CPU0 CPU1
0: 793303 0 IO-APIC-edge apbt0
8: 84124 0 IO-APIC-fasteoi dw_spi
13: 0 0 IO-APIC-fasteoi INTEL_MID_DMAC2
15: 1851630 0 IO-APIC-fasteoi mrstouch
27: 83 0 IO-APIC-fasteoi mmc0l_scu_ipc
28: 0 0 IO-APIC-fasteoi mmc1
30: 0 0 IO-APIC-fasteoi INTEL_MID_DMAC1
33: 23 0 IO-APIC-fasteoi ehci_hcd:usb1
34: 52 0 IO-APIC-fasteoi mmc2
39: 0 812273 IO-APIC-edge apbt1
> Also, i guess this would be .40 material, right?
Without the patch, kernel will crash during boot on Moorestown since
the secondary CPU clockevent (apbt1) will fail to request irq#1, which
does not have ioapic chip in its irq_desc[] entry. So, I would think
this is an urgent bug fix for 39.
--
Thanks
Jacob
(from Linux laptop)
next prev parent reply other threads:[~2011-04-11 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 18:23 Jacob Pan
2011-04-10 6:01 ` Ingo Molnar
2011-04-11 16:43 ` jacob pan [this message]
2011-04-12 6:35 ` Ingo Molnar
2011-04-12 7:40 ` [tip:x86/urgent] x86/mrst: Fix boot crash caused by incorrect " tip-bot for Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411094330.69c86910@jacob-laptop \
--to=jacob.jun.pan@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®