From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Nat Gurumoorthy <natg@google.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <guenter.roeck@ericsson.com>,
Wim Van Sebroeck <wim@iguana.be>,
Mike Waychison <mikew@google.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v4 1/2] Use "request_muxed_region" in it87 watchdog drivers
Date: Tue, 12 Apr 2011 12:41:55 +0100 [thread overview]
Message-ID: <20110412124155.36787390@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1302565974-23906-1-git-send-email-natg@google.com>
> + while (!request_muxed_region(REG, 2, NAME))
> + continue;
> +
This shouldn't need the loop ? - is it only working with the loop
present ?
Otherwise this looks good - I'd just like to understand if the loop was
needed (indicating a bug has crept into the muxed alloc code somewhere
perhaps) or not
Alan
next prev parent reply other threads:[~2011-04-12 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 23:50 [PATCH v4 0/2] Make all it87 drivers SMP safe Nat Gurumoorthy
2011-04-11 23:52 ` [PATCH v4 1/2] Use "request_muxed_region" in it87 watchdog drivers Nat Gurumoorthy
2011-04-12 11:41 ` Alan Cox [this message]
2011-04-12 15:46 ` Natarajan Gurumoorthy
2011-04-11 23:53 ` [PATCH v4 2/2] Use "request_muxed_region" in it87 hwmon drivers Nat Gurumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412124155.36787390@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mikew@google.com \
--cc=natg@google.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®