From: "tj@kernel.org" <tj@kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Shaohua Li <shaohua.li@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"cl@linux.com" <cl@linux.com>
Subject: Re: [PATCH 3/4]percpu_counter: fix code for 32bit systems
Date: Wed, 13 Apr 2011 13:00:13 +0900 [thread overview]
Message-ID: <20110413040013.GB24161@mtj.dyndns.org> (raw)
In-Reply-To: <1302666820.2811.115.camel@edumazet-laptop>
Hello,
On Wed, Apr 13, 2011 at 05:53:40AM +0200, Eric Dumazet wrote:
> Le mercredi 13 avril 2011 à 11:03 +0800, Shaohua Li a écrit :
> > I can do this, but please give a reason. If network code is the only
> > place requiring disable irq, why not network code do it?
>
> Lot of percpu_counter users dont use full s64 range, but "unsigned long"
> or "unsigned int". Adding a lock on 32bit arches to get the s64, then
> truncate it is not needed.
Yeah, it might hurt 32bit archs a bit but if 64bit becomes better I'll
take that any day. Also, atomic64_t implementation on x86-32 seems
pretty good and doesn't depend on irq spinlocks (which is quite
expensive), so it shouldn't be too bad.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-04-13 4:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 8:04 Shaohua Li
2011-04-12 9:03 ` Eric Dumazet
2011-04-13 1:01 ` Shaohua Li
2011-04-13 2:32 ` Eric Dumazet
2011-04-13 2:41 ` Shaohua Li
2011-04-13 2:47 ` Eric Dumazet
2011-04-13 3:03 ` Shaohua Li
2011-04-13 3:50 ` tj
2011-04-13 4:37 ` Shaohua Li
2011-04-13 3:53 ` Eric Dumazet
2011-04-13 4:00 ` tj [this message]
2011-04-12 19:02 ` Tejun Heo
2011-04-13 1:05 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413040013.GB24161@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®