Re: [PATCH 1/5] usb/gadget: cleanup of "Add SuperSpeed support to the Gadget Framework"

[Felipe Balbi <balbi@ti.com>]

Hi,

On Tue, Apr 12, 2011 at 09:34:52PM +0200, Sebastian Andrzej Siewior wrote:
> style, some endianess fixups
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/usb/gadget/Kconfig     |    1 -
>  drivers/usb/gadget/composite.c |   62 +++++++++++++++++----------------------
>  include/linux/usb/gadget.h     |    2 +-
>  3 files changed, 28 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index b4130bc..21429c7 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -609,7 +609,6 @@ config USB_GADGET_SUPERSPEED
>  	boolean "Gadget operating in Super Speed"
>  	depends on USB_GADGET
>  	depends on USB_GADGET_DUALSPEED
> -	default n
>  	help
>  	  Enabling this feature enables Super Speed support in the Gadget
>  	  driver. It means that gadget drivers should provide extra (SuperSpeed)
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index d5fe1c2..a94b7b7 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -76,10 +76,7 @@ static char composite_manufacturer[50];
>  /* Default endpoint companion descriptor */
>  static struct usb_ss_ep_comp_descriptor default_ep_comp_desc = {
>  		.bDescriptorType = USB_DT_SS_ENDPOINT_COMP,
> -		.bLength = 0x06,
> -		.bMaxBurst = 0, /* the default is we don't support bursting */
> -		.bmAttributes = 0, /* 2^0 streams supported */
> -		.wBytesPerInterval = 0,
> +		.bLength = sizeof(struct usb_ss_ep_comp_descriptor),

actually, there's a define:

#define USB_DT_SS_EP_COMP_SIZE		6

-- 
balbi