From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Nat Gurumoorthy <natg@google.com>,
Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <guenter.roeck@ericsson.com>,
Mike Waychison <mikew@google.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v5 1/2] Use "request_muxed_region" in it87 watchdog drivers
Date: Wed, 13 Apr 2011 10:29:47 +0100 [thread overview]
Message-ID: <20110413102947.3bf1cc88@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110413070259.GE4070@infomag.iguana.be>
On Wed, 13 Apr 2011 09:03:00 +0200
Wim Van Sebroeck <wim@iguana.be> wrote:
> Hi Nat,
>
> > + (void) request_muxed_region(REG, 2, NAME);
>
> Why do we need to typecast this? Can't we just use
> + request_muxed_region(REG, 2, NAME);
We really ought to use
if ()
in theory the request can fail if someone has hogged the resource and not
muxed it. I'm not clear what the right thing to do in that case is -
given it should never happen I guess log an error and bail out but that's
a rather bigger change and perhaps should be a follow up patch ?
next prev parent reply other threads:[~2011-04-13 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 20:48 [PATCH v5 0/2] Make all it87 drivers SMP safe Nat Gurumoorthy
2011-04-12 20:49 ` [PATCH v5 1/2] Use "request_muxed_region" in it87 watchdog drivers Nat Gurumoorthy
2011-04-13 6:50 ` [lm-sensors] " Hans de Goede
2011-04-13 8:05 ` Natarajan Gurumoorthy
2011-04-13 8:34 ` Jean Delvare
2011-04-13 17:59 ` Natarajan Gurumoorthy
2011-04-13 20:34 ` Jean Delvare
2011-04-14 9:25 ` Alan Cox
2011-04-14 17:58 ` Guenter Roeck
2011-04-13 7:03 ` Wim Van Sebroeck
2011-04-13 8:15 ` Natarajan Gurumoorthy
2011-04-13 9:29 ` Alan Cox [this message]
2011-04-14 19:00 ` Mike Waychison
2011-04-14 20:41 ` Alan Cox
2011-04-12 20:50 ` [PATCH v5 2/2] Use "request_muxed_region" in it87 hwmon drivers Nat Gurumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413102947.3bf1cc88@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mikew@google.com \
--cc=natg@google.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®