From: Jean Delvare <khali@linux-fr.org>
To: wni@nvidia.com
Cc: guenter.roeck@ericsson.com, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org, olofj@chromium.org,
achew@nvidia.com
Subject: Re: [PATCH] [hwmon] lm90: Support NCT1008 sensor
Date: Wed, 13 Apr 2011 14:53:21 +0200 [thread overview]
Message-ID: <20110413145321.181484bf@endymion.delvare> (raw)
In-Reply-To: <1302695508-2002-1-git-send-email-wni@nvidia.com>
Hi Wei,
On Wed, 13 Apr 2011 19:51:48 +0800, wni@nvidia.com wrote:
> From: Wei Ni <wni@nvidia.com>
>
> NCT1008 is the register-compatible with the ADM1032 and ADT7461,
> so support it in this lm90 driver.
> And add alarm function, suspend/resume callback.
We already have a patch pending adding support for the NCT1008:
ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-hwmon/hwmon-lm90-01-add-support-for-adt7461a-and-nct1008.patch
Your own patch should apply on top of this, and only focus on adding
support for the new features. BTW, you stand a better chance of getting
your changes reviewed and accepted quickly if you split them into
logical steps. For example, suspend/resume support would be useful on
its own, so it could be a separate patch, etc.
--
Jean Delvare
prev parent reply other threads:[~2011-04-13 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 11:51 wni
2011-04-13 12:53 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413145321.181484bf@endymion.delvare \
--to=khali@linux-fr.org \
--cc=achew@nvidia.com \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=olofj@chromium.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®