From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932884Ab1DMQNJ (ORCPT ); Wed, 13 Apr 2011 12:13:09 -0400 Received: from kroah.org ([198.145.64.141]:52859 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932747Ab1DMQNG (ORCPT ); Wed, 13 Apr 2011 12:13:06 -0400 X-Mailbox-Line: From gregkh@clark.kroah.org Wed Apr 13 09:10:46 2011 Message-Id: <20110413161046.188832683@clark.kroah.org> User-Agent: quilt/0.48-16.4 Date: Wed, 13 Apr 2011 09:09:58 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Vasiliy Kulikov , "Gustavo F. Padovan" Subject: [35/71] Bluetooth: sco: fix information leak to userspace In-Reply-To: <20110413161106.GA20405@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.33-longterm review patch. If anyone has any objections, please let us know. ------------------ From: Vasiliy Kulikov commit c4c896e1471aec3b004a693c689f60be3b17ac86 upstream. struct sco_conninfo has one padding byte in the end. Local variable cinfo of type sco_conninfo is copied to userspace with this uninizialized one byte, leading to old stack contents leak. Signed-off-by: Vasiliy Kulikov Signed-off-by: Gustavo F. Padovan Signed-off-by: Greg Kroah-Hartman --- net/bluetooth/sco.c | 1 + 1 file changed, 1 insertion(+) --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -701,6 +701,7 @@ static int sco_sock_getsockopt_old(struc break; } + memset(&cinfo, 0, sizeof(cinfo)); cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle; memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);