Re: [PATCH] x86: Clean up mwait_play_dead

[Ingo Molnar <mingo@elte.hu>]

* Borislav Petkov <bp@amd64.org> wrote:

> On Wed, Apr 13, 2011 at 09:52:40AM -0700, H. Peter Anvin wrote:
> > On 04/13/2011 09:11 AM, Frank Arnold wrote:
> > > From: Frank Arnold <frank.arnold@amd.com>
> > > 
> > > Commit 93789b32dbf355e70f18b17a82e8661677a7f7fb introduced
> > > cpuinfo_x86 *c for brevity. It is used to check for the
> > > mwait feature flag. The same can be done with a subsequent
> > > check for clflsh and save us a second per-cpu pointer
> > > dereference.
> > > 
> > > Signed-off-by: Frank Arnold <frank.arnold@amd.com>
> > > Acked-by: Borislav Petkov <borislav.petkov@amd.com>
> > > ---
> > >  arch/x86/kernel/smpboot.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > 
> > This should be using this_cpu_has()... if that's not in the tree yet we
> > should add it.
> 
> Looks like it is still in tip/x86/mm.

Yeah - that patch was sent at around the beginning of the merge window, so it 
was too late for .39.

> We could either redo the patch properly when this_cpu_has() is merged or add 
> the change against that branch.

Yeah - please do one against tip:master and we'll put it into the right topic 
branch.

Thanks,

	Ingo