From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] gpio: add pin biasing and drive mode to gpiolib
Date: Sun, 17 Apr 2011 22:48:16 +0100 [thread overview]
Message-ID: <20110417224816.38ddffee@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1303076273-8093-1-git-send-email-linus.walleij@stericsson.com>
> + * enum gpio_drive - drive modes for GPIOs (output)
> + * @GPIO_DRIVE_PUSH_PULL: the GPIO will be driven actively high and low, this
> + * is the most typical case and is typically achieved with two active
> + * transistors on the output
> + * @GPIO_DRIVE_OPEN_DRAIN: the GPIO will be driven with open drain (open
> + * collector) which means it is usually wired with other output ports
> + * which are then pulled up with an external resistor
> + * @GPIO_DRIVE_OPEN_SOURCE: the GPIO will be driven with open drain
> + * (open emitter) which is the same as open drain mutatis mutandis but
> + * pulled to ground
How about "off". As I've pointed out at various times some devices have
GPIO pins that may or may not be connected depending upon what other chip
logic is doing.
As I've also noted with various other previous suggestions for API
additions you also need an "unknown" state so that a device can implement
the methods but indicate for some pins the value is unknown due to
hardware or firmware limitations.
next prev parent reply other threads:[~2011-04-17 21:47 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 21:37 Linus Walleij
2011-04-17 21:48 ` Alan Cox [this message]
2011-04-17 21:58 ` Linus Walleij
2011-04-17 22:03 ` Alan Cox
2011-04-18 0:09 ` Kyungmin Park
2011-04-18 7:17 ` Kurt Van Dijck
2011-04-18 8:04 ` Ben Nizette
2011-04-18 8:19 ` Alan Cox
2011-04-18 8:50 ` Ben Nizette
2011-04-18 11:59 ` Mark Brown
2011-04-18 22:16 ` Ben Nizette
2011-04-18 22:31 ` Mark Brown
2011-04-19 4:50 ` Ben Nizette
2011-04-20 12:11 ` Linus Walleij
2011-04-18 12:26 ` Alan Cox
2011-04-18 22:26 ` Ben Nizette
2011-04-19 8:38 ` Alan Cox
2011-04-19 8:51 ` Kyungmin Park
2011-04-20 12:32 ` Linus Walleij
2011-04-20 12:38 ` Kyungmin Park
2011-04-20 14:54 ` Alan Cox
2011-04-20 14:26 ` Haojian Zhuang
2011-04-20 14:40 ` Kyungmin Park
2011-04-20 15:04 ` Haojian Zhuang
2011-04-20 15:17 ` Linus Walleij
2011-04-20 15:32 ` Alan Cox
2011-04-20 15:45 ` Linus Walleij
2011-04-27 21:55 ` Russell King - ARM Linux
2011-04-27 22:16 ` H Hartley Sweeten
2011-04-20 15:13 ` Linus Walleij
2011-04-20 15:29 ` Alan Cox
2011-04-20 15:39 ` Linus Walleij
2011-04-20 15:43 ` Alan Cox
2011-04-27 21:58 ` Russell King - ARM Linux
2011-04-20 0:09 ` Ben Nizette
2011-04-20 9:45 ` Alan Cox
2011-04-20 12:38 ` Linus Walleij
2011-04-20 14:55 ` Alan Cox
2011-04-20 12:21 ` Linus Walleij
2011-04-20 23:32 ` Ben Nizette
2011-04-21 6:48 ` Linus Walleij
2011-04-23 8:25 ` Ben Nizette
2011-04-21 0:29 ` Ben Nizette
2011-04-20 12:19 ` Linus Walleij
2011-04-20 12:22 ` Alan Cox
2011-04-20 12:04 ` Linus Walleij
2011-04-20 23:24 ` Ben Nizette
2011-04-21 15:39 ` Stijn Devriendt
2011-04-22 11:36 ` Linus Walleij
2011-04-22 11:56 ` Alan Cox
2011-04-23 8:35 ` Ben Nizette
2011-04-25 18:52 ` Rohit Vaswani
2011-04-26 7:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110417224816.38ddffee@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®