From: David Miller <davem@davemloft.net>
To: decot@google.com
Cc: jes@trained-monkey.org, linux-acenic@sunsite.dk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acenic: Fix using the specified speed when configuring NIC
Date: Mon, 18 Apr 2011 22:46:42 -0700 (PDT) [thread overview]
Message-ID: <20110418.224642.71106517.davem@davemloft.net> (raw)
In-Reply-To: <1303001827-4283-1-git-send-email-decot@google.com>
From: David Decotigny <decot@google.com>
Date: Sat, 16 Apr 2011 17:57:07 -0700
> This patch needs review, as I did not test it: I only think something
> is weird by looking at the code, but experts must confirm.
>
> This tells the NIC to take the speed specified by ethtool into account
> when configuring the NIC, instead of keeping the previous speed.
>
> Signed-off-by: David Decotigny <decot@google.com>
Looks correct, but seems to be dependent upon some other patches which
have feedback pending which you need to address.
Please resubmit that when the other series ends up being applied after
you've fixed it up.
prev parent reply other threads:[~2011-04-19 5:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 0:57 David Decotigny
2011-04-19 5:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418.224642.71106517.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=decot@google.com \
--cc=jes@trained-monkey.org \
--cc=linux-acenic@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome