From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756286Ab1DRSNh (ORCPT ); Mon, 18 Apr 2011 14:13:37 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:23740 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754715Ab1DRSNd (ORCPT ); Mon, 18 Apr 2011 14:13:33 -0400 Date: Mon, 18 Apr 2011 11:12:51 -0700 From: Randy Dunlap To: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: akpm@linux-foundation.org, jkosina@suse.cz, Alan Ott Subject: [PATCH -next] hid-example: fix some build issues Message-Id: <20110418111251.8a922b6b.randy.dunlap@oracle.com> In-Reply-To: <201104142149.p3ELnnoF008424@imap1.linux-foundation.org> References: <201104142149.p3ELnnoF008424@imap1.linux-foundation.org> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: acsmt358.oracle.com [141.146.40.158] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4DAC7F26.006F:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap samples/hid-example.o needs some Kconfig and Makefile additions in order to build. It should use headers from the build tree, so use HEADERS_CHECK to require that those header files be present. Change the kconfig symbol from tristate to bool since userspace cannot be built as loadable modules. However, I don't understand why the userspace header files are not present as reported in Andrew's build log, since it builds OK on x86_64 without any of these changes. Reported-by: Andrew Morton Signed-off-by: Randy Dunlap Cc: Alan Ott Cc: Jiri Kosina Cc: linux-input@vger.kernel.org --- samples/Kconfig | 4 ++-- samples/hidraw/Makefile | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) --- linux-next-20110418.orig/samples/hidraw/Makefile +++ linux-next-20110418/samples/hidraw/Makefile @@ -6,3 +6,5 @@ hostprogs-y := hid-example # Tell kbuild to always build the programs always := $(hostprogs-y) + +HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include --- linux-next-20110418.orig/samples/Kconfig +++ linux-next-20110418/samples/Kconfig @@ -62,8 +62,8 @@ config SAMPLE_KDB command to the kdb shell. config SAMPLE_HIDRAW - tristate "Build simple hidraw example" - depends on HIDRAW + bool "Build simple hidraw example" + depends on HIDRAW && HEADERS_CHECK help Build an example of how to use hidraw from userspace.