Re: [PATCH] drm: Add a driver for kvm emulated Cirrus

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

So has this been benchmarked - intuitively I'd agree and expect that a
shadowfb driver ought to give best performance.

> +/* Map the framebuffer from the card and configure the core */
> +static int cirrus_vram_init(struct cirrus_device *cdev)
> +{
> +	int ret;
> +
> +	/* BAR 0 is VRAM */
> +	cdev->mc.vram_base = pci_resource_start(cdev->ddev->pdev, 0);
> +	/* We have 4MB of VRAM */
> +	cdev->mc.vram_size = 4 * 1024 * 1024;

For real hardware at least you should check that the pci resource is at
least 4Mb long before doing this, otherwise the resulting progression in
the fail case is that you map some other device into user address space,
which isn't good!

> +static void cirrus_encoder_mode_set(struct drm_encoder *encoder,
> +				struct drm_display_mode *mode,
> +				struct drm_display_mode *adjusted_mode)
> +{
> +	struct drm_device *dev = encoder->dev;
> +	struct cirrus_device *cdev = dev->dev_private;
> +
> +	unsigned char tmp;
> +
> +	switch (encoder->crtc->fb->bits_per_pixel) {
> +	case 8:
> +		tmp = 0x0;
> +		break;
> +	case 16:
> +		/* Enable 16 bit mode */
> +		WREG_HDR(0x01);

If you switch back from 16 does this not need clearing ?


Alan