From: Sean Young <sean@mess.org>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Robin Becker <robin@reportlab.com>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-kernel@vger.kernel.org
Subject: [PATCH] arm: mach-kirkwood: leds on eSATA SheevaPlug regression
Date: Tue, 19 Apr 2011 17:41:57 +0100 [thread overview]
Message-ID: <20110419164157.GA7373@pequod.mess.org> (raw)
Fix regression in 2.6.39-rc2 on eSATA SheevaPlug where the leds are no
longer probed correctly.
[ 6.188278] leds-gpio: probe of leds-gpio failed with error -22
Also add missing blue led which was incorrectly wired to the green led.
Tested on both SheevaPlug models (original and eSATA).
Signed-off-by: Robin Becker <robin@reportlab.com>
Signed-off-by: Sean Young <sean@mess.org>
---
diff --git a/arch/arm/mach-kirkwood/sheevaplug-setup.c b/arch/arm/mach-kirkwood/sheevaplug-setup.c
index 17de0bf..e6b864a 100644
--- a/arch/arm/mach-kirkwood/sheevaplug-setup.c
+++ b/arch/arm/mach-kirkwood/sheevaplug-setup.c
@@ -65,6 +65,12 @@ static struct gpio_led sheevaplug_led_pins[] = {
},
{
.name = "plug:green:health",
+ .default_trigger = "none",
+ .gpio = 48,
+ .active_low = 1,
+ },
+ {
+ .name = "plug:blue:health",
.default_trigger = "default-on",
.gpio = 49,
.active_low = 1,
@@ -87,15 +93,18 @@ static struct platform_device sheevaplug_leds = {
static unsigned int sheevaplug_mpp_config[] __initdata = {
MPP29_GPIO, /* USB Power Enable */
MPP46_GPIO, /* LED Red */
- MPP49_GPIO, /* LED */
+ MPP48_GPIO, /* LED Green */
+ MPP49_GPIO, /* LED Blue */
0
};
static unsigned int sheeva_esata_mpp_config[] __initdata = {
MPP29_GPIO, /* USB Power Enable */
MPP44_GPIO, /* SD Write Protect */
+ MPP46_GPIO, /* LED Red */
MPP47_GPIO, /* SD Card Detect */
- MPP49_GPIO, /* LED Green */
+ MPP48_GPIO, /* LED Green */
+ MPP49_GPIO, /* LED Blue */
0
};
reply other threads:[~2011-04-19 16:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419164157.GA7373@pequod.mess.org \
--to=sean@mess.org \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=robin@reportlab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®