mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Stephane Chatty <chatty@lii-enac.fr>,
	PenMount <penmount.touch@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: hid-multitouch: refactor last_field_index
Date: Thu, 21 Apr 2011 14:45:05 +0200	[thread overview]
Message-ID: <20110421124505.GA7916@polaris.bitmath.org> (raw)
In-Reply-To: <1303388160-2814-2-git-send-email-benjamin.tissoires@enac.fr>

On Thu, Apr 21, 2011 at 02:15:59PM +0200, Benjamin Tissoires wrote:
> the current implementation requires the devices to report
> HID_DG_CONTACTCOUNT to set the last_field_index value.
> However, devices reporting in serial mode (DWAV and PenMount)
> do not send this field.
> Other devices (3M) add other fields in the reports descriptor
> that are not multitouch related at the end, thus the need to
> add a special case in the default case when handling events.
> 
> A first work around has been set up but with PenMount devices,
> we have reached the limit.
> 
> The idea is to calculate the last_field_index by relying only on
> multitouch fields the device send. This allows us to remove
> the handling of non-multitouch events in hid-multitouch, and
> guarantee that the function mt_emit_event is always called.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
> ---

Reviewed-and-tested-by: Henrik Rydberg <rydberg@euromail.se>

Thanks,
Henrik

  reply	other threads:[~2011-04-21 12:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 12:15 [PATCH 0/2] Support for PenMount devices Benjamin Tissoires
2011-04-21 12:15 ` [PATCH 1/2] HID: hid-multitouch: refactor last_field_index Benjamin Tissoires
2011-04-21 12:45   ` Henrik Rydberg [this message]
2011-04-22  9:55     ` Jiri Kosina
2011-04-21 12:16 ` [PATCH 2/2] HID: add support for PenMount dual-touch panel Benjamin Tissoires
2011-04-21 12:18   ` Jiri Kosina
2011-04-21 12:19     ` Benjamin Tissoires
2011-04-21 12:45   ` Henrik Rydberg
2011-04-21 14:21   ` [PATCH] " Benjamin Tissoires
2011-04-22  9:57     ` Jiri Kosina
2011-04-22 10:12       ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110421124505.GA7916@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=benjamin.tissoires@enac.fr \
    --cc=chatty@lii-enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penmount.touch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome