From: Francois Romieu <romieu@fr.zoreil.com>
To: Ciprian Docan <docan@eden.rutgers.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"Rafael, J. Wysocki" <rjw@sisk.pl>, Greg KH <gregkh@suse.de>,
nic_swsd@realtek.com
Subject: Re: Suspend/resume - slow resume
Date: Thu, 21 Apr 2011 15:02:19 +0200 [thread overview]
Message-ID: <20110421130219.GA19021@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <Pine.SOC.4.64.1104202204090.1320@er3.rutgers.edu>
Ciprian Docan <docan@eden.rutgers.edu> :
[...]
> @@ -1789,25 +1800,26 @@ rtl_phy_write_fw(struct rtl8169_private *tp, const struct firmware *fw)
>
> static void rtl_release_firmware(struct rtl8169_private *tp)
> {
> - release_firmware(tp->fw);
> - tp->fw = NULL;
> + if (!IS_ERR_OR_NULL(tp->fw))
> + release_firmware(tp->fw);
Ok.
Nit: the test against NULL is not needed here.
--
Ueimor
prev parent reply other threads:[~2011-04-21 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.SOC.4.64.1104150931390.1320@er3.rutgers.edu>
[not found] ` <BANLkTinO+HFq+Mgg1aUz9V==zYs7qSBtDw@mail.gmail.com>
[not found] ` <Pine.SOC.4.64.1104151122330.1320@er3.rutgers.edu>
2011-04-15 16:14 ` Linus Torvalds
2011-04-17 10:17 ` Francois Romieu
2011-04-17 16:42 ` Linus Torvalds
2011-04-18 18:08 ` Francois Romieu
2011-04-18 18:49 ` Linus Torvalds
2011-04-18 19:25 ` Ben Hutchings
2011-04-18 19:27 ` Ciprian Docan
2011-04-18 19:51 ` Linus Torvalds
2011-04-20 18:16 ` Francois Romieu
2011-04-20 18:51 ` Ciprian Docan
2011-04-20 19:52 ` Francois Romieu
2011-04-20 19:10 ` Ciprian Docan
2011-04-20 19:53 ` Francois Romieu
2011-04-21 2:07 ` Ciprian Docan
2011-04-21 13:02 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421130219.GA19021@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=docan@eden.rutgers.edu \
--cc=gregkh@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®