From: Randy Dunlap <randy.dunlap@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL PATCH] treewide: Cleanup continuations and remove logging message whitespace
Date: Mon, 25 Apr 2011 08:22:30 -0700 [thread overview]
Message-ID: <20110425082230.6d656ed0.randy.dunlap@oracle.com> (raw)
In-Reply-To: <65136ab68431de0cc0c554663cee33fc9d4a9850.1303615717.git.joe@perches.com>
On Sat, 23 Apr 2011 20:38:19 -0700 Joe Perches wrote:
> Using C line continuation inside format strings is error prone.
> Clean up the unintended whitespace introduced by misuse of \.
> Neaten correctly used line continations as well for consistency.
>
> drivers/scsi/arcmsr/arcmsr_hba.c has these errors as well,
> but arcmsr needs a lot more work and the driver should likely be
> moved to staging instead.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/arm/plat-mxc/cpufreq.c | 4 +-
> drivers/dma/dmatest.c | 4 +-
> drivers/firmware/iscsi_ibft.c | 4 +-
> drivers/gpio/ab8500-gpio.c | 7 ++---
> drivers/media/video/usbvision/usbvision-video.c | 5 ++-
> drivers/message/fusion/mptbase.c | 22 ++++++++----------
> drivers/misc/bh1780gli.c | 8 +++---
> drivers/misc/spear13xx_pcie_gadget.c | 4 +-
> drivers/net/atlx/atl1.c | 5 ++-
> drivers/net/wireless/airo.c | 27 ++++++++++++-----------
> drivers/net/wireless/iwlegacy/iwl-4965-calib.c | 4 +-
> drivers/net/wireless/iwlwifi/iwl-agn-calib.c | 4 +-
> drivers/regulator/max8998.c | 4 +-
> drivers/tty/serial/bfin_sport_uart.c | 3 +-
> drivers/tty/serial/mfd.c | 4 +-
> drivers/usb/host/uhci-hcd.c | 7 +++--
> drivers/usb/storage/ene_ub6250.c | 4 +-
> 17 files changed, 60 insertions(+), 60 deletions(-)
Joe,
Is there a decent fix for this warning in linux-next:
drivers/tty/n_gsm.c:535: warning: zero-length gnu_printf format string
thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-04-25 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 3:38 Joe Perches
2011-04-25 15:22 ` Randy Dunlap [this message]
2011-04-25 23:46 ` [PATCH] n_gsm: Use print_hex_dump_bytes Joe Perches
2011-04-26 1:15 ` Randy Dunlap
2011-04-26 2:48 ` [TRIVIAL PATCH] treewide: Cleanup continuations and remove logging message whitespace Harry Wei
2011-04-26 16:34 ` Randy Dunlap
2011-04-27 1:37 ` Harry Wei
2011-04-26 8:25 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110425082230.6d656ed0.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome