mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: <pefoley2@verizon.net>, David Rientjes <rientjes@google.com>
Cc: <linux-kernel@vger.kernel.org>, akpm <akpm@linux-foundation.org>,
	torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] init: restore the EXPERT kconfig menu
Date: Mon, 25 Apr 2011 18:37:23 -0700	[thread overview]
Message-ID: <20110425183723.36c80ae1.randy.dunlap@oracle.com> (raw)
In-Reply-To: <4DB61913.6090907@verizon.net>

On Mon, 25 Apr 2011 21:00:03 -0400 Peter Foley wrote:

> This patch changes CONFIG_EXPERT from a menuconfig to a config
> because it no longer has any child items and is therefore an empty menu.
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
>  init/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 56240e7..332a2b3 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -916,7 +916,7 @@ config SYSCTL
>  config ANON_INODES
>  	bool
> 
> -menuconfig EXPERT
> +config EXPERT
>  	bool "Configure standard kernel features (expert users)"
>  	help
>  	  This option allows certain base kernel options and settings
> -- 

NAK.  Just restore the EXPERT menu.  Patch below.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Restore the EXPERT menu list -- don't inject a symbol (EMBEDDED)
that does not depend on EXPERT into the list.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Rientjes <rientjes@google.com>
---
 init/Kconfig |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

--- lnx-2639-rc4.orig/init/Kconfig
+++ lnx-2639-rc4/init/Kconfig
@@ -924,14 +924,6 @@ menuconfig EXPERT
           environments which can tolerate a "non-standard" kernel.
           Only use this if you really know what you are doing.
 
-config EMBEDDED
-	bool "Embedded system"
-	select EXPERT
-	help
-	  This option should be enabled if compiling the kernel for
-	  an embedded system so certain expert options are available
-	  for configuration.
-
 config UID16
 	bool "Enable 16-bit UID system calls" if EXPERT
 	depends on ARM || BLACKFIN || CRIS || FRV || H8300 || X86_32 || M68K || (S390 && !64BIT) || SUPERH || SPARC32 || (SPARC64 && COMPAT) || UML || (X86_64 && IA32_EMULATION)
@@ -1104,6 +1096,14 @@ config AIO
           by some high performance threaded applications. Disabling
           this option saves about 7k.
 
+config EMBEDDED
+	bool "Embedded system"
+	select EXPERT
+	help
+	  This option should be enabled if compiling the kernel for
+	  an embedded system so certain expert options are available
+	  for configuration.
+
 config HAVE_PERF_EVENTS
 	bool
 	help

      reply	other threads:[~2011-04-26  1:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26  1:00 [PATCH] init: change EXPERT from menuconfig to config to remove an empty menu Peter Foley
2011-04-26  1:37 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110425183723.36c80ae1.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pefoley2@verizon.net \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome