From: Felipe Balbi <balbi@ti.com>
To: Graeme Gregory <gg@slimlogic.co.uk>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
sameo@linux.intel.com, balbi@ti.com, lrg@slimlogic.co.uk,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH 4/4] USB: TWL6025 allow different regulator name
Date: Wed, 27 Apr 2011 13:45:44 +0300 [thread overview]
Message-ID: <20110427104542.GZ13227@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1303897191-14792-5-git-send-email-gg@slimlogic.co.uk>
Hi,
On Wed, Apr 27, 2011 at 10:39:51AM +0100, Graeme Gregory wrote:
> The twl6025 uses a different regulator for USB than the 6030 so select
> the correct regulator name depending on the subclass of device.
>
> Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
I don't see the point of this patch. It's just a string. Use the same
name and add a comment saying that on datasheet/TRM/documentation the
name LDO is actually referred to as LDOUSB. It's the same functionality
anyway.
--
balbi
next prev parent reply other threads:[~2011-04-27 10:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 9:39 [PATCH 0/4] Add support for twl6025 PMIC Graeme Gregory
2011-04-27 9:39 ` [PATCH 1/4] MFD: TWL6025: add phoenix lite support to twl6030 Graeme Gregory
2011-04-27 10:40 ` Felipe Balbi
2011-05-08 20:32 ` Liam Girdwood
2011-04-27 9:39 ` [PATCH 2/4] MFD: TWL6030: fix irq definitions Graeme Gregory
2011-04-27 9:39 ` [PATCH 3/4] REGULATOR: TWL6025: add support to twl-regulator Graeme Gregory
2011-04-27 10:43 ` Felipe Balbi
2011-04-27 11:08 ` Mark Brown
2011-04-27 9:39 ` [PATCH 4/4] USB: TWL6025 allow different regulator name Graeme Gregory
2011-04-27 10:45 ` Felipe Balbi [this message]
2011-05-08 15:08 ` Liam Girdwood
2011-05-09 9:03 ` Felipe Balbi
2011-05-09 11:43 ` Liam Girdwood
2011-05-09 12:16 ` Felipe Balbi
2011-05-09 12:29 ` Mark Brown
2011-05-09 13:07 ` Felipe Balbi
2011-05-09 13:35 ` Mark Brown
2011-05-09 13:51 ` Felipe Balbi
2011-05-09 15:17 ` Mark Brown
2011-05-09 13:11 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427104542.GZ13227@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®