From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] i2c: append hardware lock with bus lock
Date: Thu, 28 Apr 2011 15:37:24 +0100 [thread overview]
Message-ID: <20110428143724.GQ17290@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110428161625.5eaacb85@endymion.delvare>
On Thu, Apr 28, 2011 at 04:16:25PM +0200, Jean Delvare wrote:
> Are you suggesting that the hardware lock wouldn't mind being taken
> twice by the AP side? If it is the case, then indeed the software mutex
> is still needed to prevent it from happening.
>
> That being said... I guess that avoiding a priority inversion is a good
> enough reason to always take the rt_mutex, regardless of the hardware
> lock implementation.
>
> So, this patch is
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
> I guess it makes more sense for me to let Ben apply it, as the other
> two patches in the series are for him too. This will avoid a dependency
> between our trees.
Only change I'd suggest is passing adapter to the hardware_lock/unlock
methods. Having no arguments what so ever in generic code for this kind
of stuff looks rather strange and limiting.
next prev parent reply other threads:[~2011-04-28 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2011042801>
2011-04-28 4:02 ` Haojian Zhuang
2011-04-28 8:22 ` Jean Delvare
2011-04-28 8:36 ` Eric Miao
2011-04-28 14:16 ` Jean Delvare
2011-04-28 14:37 ` Russell King - ARM Linux [this message]
2011-04-28 14:48 ` Haojian Zhuang
2011-04-28 14:19 ` Haojian Zhuang
2011-04-28 4:02 ` [PATCH 2/3] i2c: pxa: support hardware lock Haojian Zhuang
2011-04-28 4:02 ` [PATCH 3/3] ARM: mmp: add hardware lock support in PXA910 Haojian Zhuang
2011-04-28 15:15 ` [PATCH 1/3] i2c: append hardware lock with bus lock Haojian Zhuang
2011-05-02 9:27 ` Ben Dooks
2011-05-02 9:46 ` Jean Delvare
2011-05-10 23:08 ` Ben Dooks
2011-04-28 15:15 ` [PATCH 2/3] i2c: pxa: support hardware lock Haojian Zhuang
2011-04-28 15:15 ` [PATCH 3/3] ARM: mmp: add hardware lock support in PXA910 Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428143724.GQ17290@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ben-linux@fluff.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®